From: Junio C Hamano <gitster@pobox•com>
To: David Turner <dturner@twopensource•com>
Cc: Duy Nguyen <pclouds@gmail•com>,
Git Mailing List <git@vger•kernel.org>, Jeff King <peff@peff•net>
Subject: Re: [RFC] On watchman support
Date: Tue, 18 Nov 2014 13:26:56 -0800 [thread overview]
Message-ID: <xmqqwq6std27.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1416345123.27401.11.camel@leckie> (David Turner's message of "Tue, 18 Nov 2014 16:12:03 -0500")
David Turner <dturner@twopensource•com> writes:
> On Tue, 2014-11-18 at 12:55 -0800, Junio C Hamano wrote:
>> I vaguely recall that the reason why we dropped it was because it
>> was too much code churn in an area that was being worked on in
>> parallel, but you may need to go back to the list archive for
>> details.
>
> OK, in that case I'll try to remember to reroll it once the rest of the
> refs stuff lands.
Sure. But I would much prefer to see us explore an arch independent
optimisation of the caller before starting to micro-optimize a leaf
function.
It is not check_refname_format() that is the real problem. It's the
fact that we do O(# of refs) work whenever we have to access the
packed-refs file. check_refname_format() is part of that, surely,
but so is reading the file, creating all of the refname structs in
memory, etc. (credit to peff@).
next prev parent reply other threads:[~2014-11-18 21:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 12:49 [RFC] On watchman support Duy Nguyen
2014-11-13 5:05 ` Torsten Bögershausen
2014-11-13 12:22 ` Duy Nguyen
2014-11-15 7:24 ` Torsten Bögershausen
2014-11-18 0:25 ` David Turner
2014-11-18 10:48 ` Duy Nguyen
2014-11-18 18:12 ` David Turner
2014-11-18 20:55 ` Junio C Hamano
2014-11-18 21:12 ` David Turner
2014-11-18 21:26 ` Junio C Hamano [this message]
2014-11-19 1:46 ` Jeff King
2014-11-28 11:13 ` Duy Nguyen
2014-12-01 20:45 ` David Turner
2014-11-19 15:26 ` Paolo Ciarrocchi
2014-11-19 16:43 ` David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwq6std27.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dturner@twopensource$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox