public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Junio C Hamano <gitster@pobox•com>
To: Stepan Kasal <kasal@ucw•cz>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Update SVN.pm
Date: Thu, 17 Apr 2014 10:39:49 -0700	[thread overview]
Message-ID: <xmqqwqenety2.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140417052438.GA13907@camelia.ucw.cz> (Stepan Kasal's message of "Thu, 17 Apr 2014 07:24:38 +0200")

Stepan Kasal <kasal@ucw•cz> writes:

> On Wed, Apr 16, 2014 at 12:13:21PM -0700, Junio C Hamano wrote:
>> Interesting.  What other strange forms can they record in their
>> repositories, I have to wonder.  Can they do
>>     2014-01-07T5:8:6.048176Z
>> for example?
>
> Roman Belinsky, the author of this fix, witnessed after large scale
> conversion that the problem happens with the hour part only.

Is this "large scale conversion" done from a SVN repository that is
created by bog standard SVN, or something else?  How certain are we
that this "hour part is broken" is the only kind of breakage in
timestamps we would encouter?

What I am trying to get at is that "we didn't see any breakage at
positions other than hour part after checking 2 million commits" is
different from "there will no breakage at positions other than hour
part", and by being slightly more lenient than necessary to cover
one observed case that triggered the patch, we can cover SVN
repositories broken in a similar but slightly different way.

Especially given that this regexp matching is not used for finding a
timestamp from random places but to parse out the datum we find at a
place where we expect to see a timestamp (check the callers), I
think loosening to allow single-digit minutes and seconds in the
same commit that allows single-digit hours would be such "slightly
more lenient than necessary" change without additional risk of
mistaking something that is not a timestamp as a timestamp.

Thanks.

next prev parent reply	other threads:[~2014-04-17 17:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-16 14:16 [PATCH] Update SVN.pm Stepan Kasal
2014-04-16 19:13 ` Junio C Hamano
2014-04-17  5:24   ` Stepan Kasal
2014-04-17 17:39     ` Junio C Hamano [this message]
2014-04-18  6:48       ` Stepan Kasal
2014-04-17 18:01 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwqenety2.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=kasal@ucw$(echo .)cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox