From: Junio C Hamano <gitster@pobox•com>
To: Duy Nguyen <pclouds@gmail•com>
Cc: Git Mailing List <git@vger•kernel.org>
Subject: Re: [PATCH] revision: introduce --exclude=<glob> to tame wildcards
Date: Fri, 30 Aug 2013 17:29:44 -0700 [thread overview]
Message-ID: <xmqqwqn2wvlz.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CACsJy8DOx8Q5kLizfeP2AgDaD8+EDsQL9xtOGphrmgG=dAabcQ@mail.gmail.com> (Duy Nguyen's message of "Sat, 31 Aug 2013 07:22:45 +0700")
Duy Nguyen <pclouds@gmail•com> writes:
> On Sat, Aug 31, 2013 at 6:55 AM, Junio C Hamano <gitster@pobox•com> wrote:
>> +static int ref_excluded(struct rev_info *revs, const char *path)
>> +{
>> + struct string_list_item *item;
>> +
>> + if (!revs->ref_excludes)
>> + return 0;
>> + for_each_string_list_item(item, revs->ref_excludes) {
>> + if (!fnmatch(item->string, path, 0))
>> + return 1;
>> + }
>> + return 0;
>> +}
>
> If you pursue this, please use wildmatch instead so it supports "foo/**".
The thought crossed my mind and I think we should match what the
existing --glob=<pattern> option does. A cursory look in
refs.c::filter_refs() used by refs.c::for_each_glob_ref_in() tells
me that we are using fnmatch without FNM_PATHNAME, so that is what
the above part does.
next prev parent reply other threads:[~2013-08-31 0:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 5:00 [PATCH] revision: add --except option Felipe Contreras
2013-08-30 5:40 ` Felipe Contreras
2013-08-30 6:32 ` Junio C Hamano
2013-08-30 7:17 ` Felipe Contreras
[not found] ` <CAPc5daVSqoE74kmsobg7RpMtiL3vzKN+ckAcWEKU_Q_wF8HYuA@mail.gmail.com>
2013-08-30 7:32 ` Felipe Contreras
2013-08-30 9:08 ` Johannes Sixt
2013-08-30 16:48 ` Junio C Hamano
2013-08-30 18:37 ` Felipe Contreras
2013-08-30 23:55 ` [PATCH] revision: introduce --exclude=<glob> to tame wildcards Junio C Hamano
2013-08-31 0:22 ` Duy Nguyen
2013-08-31 0:29 ` Junio C Hamano [this message]
2013-08-31 19:33 ` Felipe Contreras
2013-09-03 15:45 ` Junio C Hamano
2013-09-03 22:03 ` Felipe Contreras
2013-09-02 20:11 ` Johannes Sixt
2013-09-02 23:09 ` Felipe Contreras
2013-09-03 4:05 ` Michael Haggerty
2013-09-03 16:03 ` Junio C Hamano
2013-09-03 20:02 ` Johannes Sixt
2013-11-01 19:34 ` [PATCH 0/5] ref glob exclusion follow-up Junio C Hamano
2013-11-01 19:34 ` [PATCH 3/5] rev-list --exclude: tests Junio C Hamano
2013-11-01 19:34 ` [PATCH 4/5] rev-list --exclude: export add/clear-ref-exclusion and ref-excluded API Junio C Hamano
2013-11-01 19:34 ` [PATCH 5/5] rev-parse: introduce --exclude=<glob> to tame wildcards Junio C Hamano
2013-11-01 19:43 ` Eric Sunshine
2013-11-01 20:01 ` Junio C Hamano
2013-11-01 21:08 ` [PATCH 0/5] ref glob exclusion follow-up Johannes Sixt
2013-08-30 7:56 ` [PATCH] revision: add --except option Johannes Sixt
2013-08-31 19:27 ` Felipe Contreras
2013-09-02 6:25 ` Johannes Sixt
2013-09-02 6:48 ` Felipe Contreras
2013-08-30 7:11 ` Johannes Sixt
2013-08-30 7:24 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwqn2wvlz.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox