From: Junio C Hamano <gitster@pobox•com>
To: "Michael S. Tsirkin" <mst@redhat•com>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>,
Johannes Schindelin <Johannes.Schindelin@gmx•de>,
git@vger•kernel.org, bafain@gmail•com, sunshine@sunshineco•com
Subject: Re: [PATCH 1/4] rebase -i: add ack action
Date: Tue, 12 Apr 2016 13:00:25 -0700 [thread overview]
Message-ID: <xmqqy48ippgm.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160412190904-mutt-send-email-mst@redhat.com> (Michael S. Tsirkin's message of "Tue, 12 Apr 2016 19:33:50 +0300")
"Michael S. Tsirkin" <mst@redhat•com> writes:
>> As to the "use commit-tree", well, personally I am not interested in
>> a solution that can work well in my workflow ONLY if I further script
>> it. That's half-solution and unless that half is done very well,
>> I'd rather do a full solution better.
>
> Absolutely. But that's not what I meant. I will add a flag to git-ack to
> select a branch and use commit-tree to put the ack commit there
> *internally*. Would this do everything you need? How do you select
> a branch? Automatically or do you remember the mapping from topic
> to branch name?
> ...
> For first part, that is less common but also happens
> (for example I get "for patches 1,7 and 23 in series: ACK") -
> I would do git ack -s
> to store David's signoff, then tag just messages by David
> (probably just using limit ~b From:\ David in mutt)
> and pipe them to git ack -r.
>
> Does this sound user-friendly enough? What would you do
> differently?
Because my workflow is I usually comment on and review many topics
without applying them to anywhere, by the time I start applying
patches, I often know which one got Acked and Reviewed already.
So for them the workflow would be
0. Think which maintenance track the topic should be based on.
1. Fork
$ git checkout -b <new topic> maint-<appropriate track>
2. In my MUA, pipe the message into this pipeline
Meta/add-by -r peff@ -a Tsirkin | git am -s3c
where the "add-by" script (found in 'todo') expands the given names
using .mailmap and appends appropriate trailers (the latter should
eventually be updated to use interpret-trailers when the tool
matures, but I did not think it was there yet when I last updated
the "add-by" script).
So for a use case where I work off of my MUA, I have no use for your
"git ack".
next prev parent reply other threads:[~2016-04-12 20:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 13:54 [PATCH 0/4] support for ack commits Michael S. Tsirkin
2016-04-10 13:54 ` [PATCH 1/4] rebase -i: add ack action Michael S. Tsirkin
2016-04-11 11:02 ` Johannes Schindelin
2016-04-11 11:24 ` Michael S. Tsirkin
2016-04-11 15:36 ` Johannes Schindelin
2016-04-11 16:41 ` Michael S. Tsirkin
2016-04-11 19:48 ` Junio C Hamano
2016-04-11 19:55 ` Michael S. Tsirkin
2016-04-11 20:03 ` Matthieu Moy
2016-04-12 7:51 ` Michael S. Tsirkin
2016-04-12 16:07 ` Junio C Hamano
2016-04-12 16:33 ` Michael S. Tsirkin
2016-04-12 20:00 ` Junio C Hamano [this message]
2016-04-11 12:05 ` Christian Neukirchen
2016-04-10 13:54 ` [PATCH 2/4] git-rebase: document ack Michael S. Tsirkin
2016-04-10 13:54 ` [PATCH 3/4] rebase: test ack Michael S. Tsirkin
2016-04-10 13:54 ` [PATCH 4/4] git-ack: record an ack Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2014-05-18 21:17 [PATCH 0/4] ack recoding in commit log Michael S. Tsirkin
2014-05-18 21:17 ` [PATCH 1/4] rebase -i: add ack action Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy48ippgm.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=Matthieu.Moy@grenoble-inp$(echo .)fr \
--cc=bafain@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox