From: Junio C Hamano <gitster@pobox•com>
To: Jeff King <peff@peff•net>
Cc: Git Mailing List <git@vger•kernel.org>,
Dan Carpenter <dan.carpenter@oracle•com>,
Mark Einon <mark.einon@gmail•com>,
Greg KH <gregkh@linuxfoundation•org>
Subject: Re: [RFC/PATCH] mailinfo: do not treat ">From" lines as in-body headers
Date: Tue, 16 Sep 2014 11:01:05 -0700 [thread overview]
Message-ID: <xmqqy4tj30ny.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140916001948.GC5019@peff.net> (Jeff King's message of "Mon, 15 Sep 2014 20:19:49 -0400")
Jeff King <peff@peff•net> writes:
> The only cases that I can think of that would be a problem with this
> strictness are:
>
> 1. Somebody writes format-patch output to a file, reads in the mbox
> using another program, and then writes out the result (munging the
> mbox From line). And then pastes the whole thing into their email
> body.
>
> I can see the first part happening. But given that it is totally
> irrelevant _unless_ they then screw up and paste the From line in
> the body (which is already a corner case), it probably doesn't
> matter.
Yeah, I tend to agree.
> 2. We change the static From lines that git generates. We can always
> update the parser, of course, but it may be running a different
> version of git than the sender. People with an old git running
> "git am" would stop skipping past "From" lines in messages from
> people on newer gits.
I hope that it is not going to happen; the reason we refrain from
ever changing the datestamp has been to keep it constant to help
those who write magic(5), and I do not think we have a reason to
defeat that.
> I think you forgot to "git add" mbox.h. That being said, if we did go
> this route, I do not see any reason to share the code at all. This can
> be purely a mailinfo.c thing.
OK. A reroll coming today when I find time.
next prev parent reply other threads:[~2014-09-16 18:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1410472786-14552-1-git-send-email-mark.einon@gmail.com>
[not found] ` <1410472786-14552-5-git-send-email-mark.einon@gmail.com>
2014-09-13 9:37 ` [PATCH 4/8] staging: et131x: Remove ununsed statistics Dan Carpenter
2014-09-13 15:45 ` Greg KH
2014-09-13 19:41 ` Dan Carpenter
2014-09-13 20:36 ` Jeff King
2014-09-13 20:47 ` Mark Einon
2014-09-13 20:57 ` Dan Carpenter
2014-09-13 21:06 ` Mark Einon
2014-09-13 21:09 ` Dan Carpenter
2014-09-13 21:25 ` [RFC/PATCH] mailinfo: do not treat ">From" lines as in-body headers Jeff King
2014-09-13 22:57 ` brian m. carlson
2014-09-14 0:47 ` Jeff King
2014-09-14 0:55 ` Junio C Hamano
2014-09-14 1:01 ` Jeff King
2014-09-14 1:30 ` Jeff King
2014-09-15 18:56 ` Junio C Hamano
2014-09-15 20:15 ` Junio C Hamano
2014-09-16 0:19 ` Jeff King
2014-09-16 18:01 ` Junio C Hamano [this message]
2014-09-16 18:41 ` Junio C Hamano
2014-09-16 20:29 ` Jeff King
2014-09-16 0:12 ` Jeff King
2014-09-15 17:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy4tj30ny.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=mark.einon@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox