* [GSoC] Add –no-sort option for git-for-each-ref
@ 2022-01-25 9:59 Shaoxuan Yuan
2022-02-01 3:23 ` Shaoxuan Yuan
0 siblings, 1 reply; 4+ messages in thread
From: Shaoxuan Yuan @ 2022-01-25 9:59 UTC (permalink / raw)
To: git
Hi git community,
I'm considering if this microproject
[https://git.github.io/Outreachy-23-Microprojects/#add-no-sort-option-for-git-for-each-ref]
is a good option for now. I want to spend some time on it and see if
I can come up with something.
Sincerely.
Shaoxuan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GSoC] Add –no-sort option for git-for-each-ref
2022-01-25 9:59 [GSoC] Add –no-sort option for git-for-each-ref Shaoxuan Yuan
@ 2022-02-01 3:23 ` Shaoxuan Yuan
2022-02-01 5:33 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Shaoxuan Yuan @ 2022-02-01 3:23 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano, Taylor Blau, ZheNing Hu, christian.couder
On Tue, Jan 25, 2022 at 5:59 PM Shaoxuan Yuan <shaoxuan.yuan02@gmail•com> wrote:
>
> Hi git community,
>
> I'm considering if this microproject
> [https://git.github.io/Outreachy-23-Microprojects/#add-no-sort-option-for-git-for-each-ref]
> is a good option for now. I want to spend some time on it and see if
> I can come up with something.
>
> Sincerely.
> Shaoxuan
Hi git community,
Not sure if this message is overlooked, but I'm writing to see if this
microproject is
still (valid to do | worth doing) for now.
Thanks,
Shaoxuan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GSoC] Add –no-sort option for git-for-each-ref
2022-02-01 3:23 ` Shaoxuan Yuan
@ 2022-02-01 5:33 ` Junio C Hamano
2022-02-01 6:01 ` Shaoxuan Yuan
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2022-02-01 5:33 UTC (permalink / raw)
To: Shaoxuan Yuan; +Cc: git, Taylor Blau, ZheNing Hu, christian.couder
Shaoxuan Yuan <shaoxuan.yuan02@gmail•com> writes:
> On Tue, Jan 25, 2022 at 5:59 PM Shaoxuan Yuan <shaoxuan.yuan02@gmail•com> wrote:
>>
>> Hi git community,
>>
>> I'm considering if this microproject
>> [https://git.github.io/Outreachy-23-Microprojects/#add-no-sort-option-for-git-for-each-ref]
>> is a good option for now. I want to spend some time on it and see if
>> I can come up with something.
I am fairly negative on that entry in the micro-project list (no, it
is not your fault), because
(1) the one that is described there is fairly useless and I do not
think we want to take in my tree at all.
(2) a variant that is any useful would be a bit too large for a
micro-project
As the explanatory text there says, the code should be able to
figure out when it does not need to make an extra ref_array_sort()
call, without being told by the user.
A smaller and more appropriate "add --no-sort and when it is given,
skip the call to ref_array_sort()" is much easier to do, but it is
very much useless.
If we were to spend any project resources (both developer's time and
reviewers' time), I'd rather not to see such an option added---once
we add a feature, we'd have to maintain it. Rather, it would be
much better use of our time to do "automatically figure out when we
do not have to sort", and with that feature, nobody needs to use the
"--no-sort" option at all.
Such an "automatically skip the call to ref_array_sort()" would be
doable by a developer who may be relatively unfamiliar with our
codebase, but is still a bit too large for a micro-project, which I
expect anybody to be able to code during a lunch break and spend
more time on review exchanges on the list.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GSoC] Add –no-sort option for git-for-each-ref
2022-02-01 5:33 ` Junio C Hamano
@ 2022-02-01 6:01 ` Shaoxuan Yuan
0 siblings, 0 replies; 4+ messages in thread
From: Shaoxuan Yuan @ 2022-02-01 6:01 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Taylor Blau, ZheNing Hu, christian.couder
On Tue, Feb 1, 2022 at 1:33 PM Junio C Hamano <gitster@pobox•com> wrote:
>
> Shaoxuan Yuan <shaoxuan.yuan02@gmail•com> writes:
>
> > On Tue, Jan 25, 2022 at 5:59 PM Shaoxuan Yuan <shaoxuan.yuan02@gmail•com> wrote:
> >>
> >> Hi git community,
> >>
> >> I'm considering if this microproject
> >> [https://git.github.io/Outreachy-23-Microprojects/#add-no-sort-option-for-git-for-each-ref]
> >> is a good option for now. I want to spend some time on it and see if
> >> I can come up with something.
>
> I am fairly negative on that entry in the micro-project list (no, it
> is not your fault), because
>
> (1) the one that is described there is fairly useless and I do not
> think we want to take in my tree at all.
>
> (2) a variant that is any useful would be a bit too large for a
> micro-project
>
> As the explanatory text there says, the code should be able to
> figure out when it does not need to make an extra ref_array_sort()
> call, without being told by the user.
>
> A smaller and more appropriate "add --no-sort and when it is given,
> skip the call to ref_array_sort()" is much easier to do, but it is
> very much useless.
>
> If we were to spend any project resources (both developer's time and
> reviewers' time), I'd rather not to see such an option added---once
> we add a feature, we'd have to maintain it. Rather, it would be
> much better use of our time to do "automatically figure out when we
> do not have to sort", and with that feature, nobody needs to use the
> "--no-sort" option at all.
>
> Such an "automatically skip the call to ref_array_sort()" would be
> doable by a developer who may be relatively unfamiliar with our
> codebase, but is still a bit too large for a micro-project, which I
> expect anybody to be able to code during a lunch break and spend
> more time on review exchanges on the list.
Hi Junio,
Thanks for the reply. Understood.
Sincerely,
Shaoxuan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-01 6:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-25 9:59 [GSoC] Add –no-sort option for git-for-each-ref Shaoxuan Yuan
2022-02-01 3:23 ` Shaoxuan Yuan
2022-02-01 5:33 ` Junio C Hamano
2022-02-01 6:01 ` Shaoxuan Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox