From: Junio C Hamano <gitster@pobox•com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail•com>
Cc: git@vger•kernel.org, David.Taylor@dell•com
Subject: Re: [PATCH] worktree add: add --lock option
Date: Sat, 15 Apr 2017 00:35:19 -0700 [thread overview]
Message-ID: <xmqqzifim8co.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170412135805.29837-1-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Wed, 12 Apr 2017 20:58:05 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail•com> writes:
> - unlink_or_warn(sb.buf);
> + if (!ret && opts->keep_locked) {
> + /*
> + * Don't keep the confusing "initializing" message
> + * after it's already over.
> + */
> + truncate(sb.buf, 0);
> + } else {
> + unlink_or_warn(sb.buf);
> + }
builtin/worktree.c: In function 'add_worktree':
builtin/worktree.c:314:11: error: ignoring return value of 'truncate', declared with attribute warn_unused_result [-Werror=unused-result]
truncate(sb.buf, 0);
^
cc1: all warnings being treated as errors
make: *** [builtin/worktree.o] Error 1
next prev parent reply other threads:[~2017-04-15 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 15:14 git work trees taylor, david
2017-04-12 13:36 ` Duy Nguyen
2017-04-12 13:58 ` [PATCH] worktree add: add --lock option Nguyễn Thái Ngọc Duy
2017-04-13 22:50 ` Junio C Hamano
2017-04-14 13:00 ` Duy Nguyen
2017-04-24 14:06 ` taylor, david
2017-04-14 16:27 ` Jacob Keller
2017-04-15 7:35 ` Junio C Hamano [this message]
2017-04-15 8:07 ` Junio C Hamano
2017-04-15 11:34 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzifim8co.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=David.Taylor@dell$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox