From: Junio C Hamano <gitster@pobox•com>
To: Stefan Beller <sbeller@google•com>
Cc: git@vger•kernel.org
Subject: Re: [RFC PATCH] format-patch: Add config option format.coverbodytext to change the cover letter body
Date: Tue, 06 Jan 2015 02:37:57 -0800 [thread overview]
Message-ID: <xmqqzj9wp52y.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1420486105-30242-1-git-send-email-sbeller@google.com> (Stefan Beller's message of "Mon, 5 Jan 2015 11:28:25 -0800")
Stefan Beller <sbeller@google•com> writes:
> When sending out patch series one of the last things doing is writing
> the cover letter. The cover letter would be a good place to remind
> people to check the todo list for sending patches.
I do not quite understand. Wouldn't a check-list be useful _before_
you start series of things (I am assuming that you meant a list like
1. run spell check; 2. run checkpatch; 3. run full test suite;
4. format the docs for HTML and manpage)? Time to write cover
letter (or running format-patch in general) is way too late for
many of these things.
There may be a check-list that is still useful after commits to be
sent are perfect and ready to be formatted. "Describe change since
the last round after three-dash line." would be one of them
("Sign-off the patch" is not---without one, the commits would not
have been perfect yet). But for such a check-list, wouldn't we want
remainder not only on the cover but on each individual patch?
Perhaps --add-header="x-reminder: what changed since the last?"
would be sufficient for your purpose instead?
next prev parent reply other threads:[~2015-01-06 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 19:28 [RFC PATCH] format-patch: Add config option format.coverbodytext to change the cover letter body Stefan Beller
2015-01-06 10:37 ` Junio C Hamano [this message]
2015-01-06 18:08 ` Stefan Beller
2015-01-06 18:57 ` Junio C Hamano
2015-01-06 19:14 ` Stefan Beller
2015-01-06 22:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzj9wp52y.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=sbeller@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox