From: p.fedin@samsung•com (Pavel Fedin)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] Documentation: dt-bindings: Describe SROMc configuration
Date: Tue, 27 Oct 2015 09:59:43 +0300 [thread overview]
Message-ID: <00b101d11085$0f9f7be0$2ede73a0$@samsung.com> (raw)
In-Reply-To: <562F0795.10900@samsung.com>
Hello!
> > +Bank configurations can be defined as an optional subnodes. They can have the
> > +following properties:
> > +- bank : bank number (0 - 3)
> > +- width : data width in bytes (1 or 2). If omitted, default of 1 is used.
> > +- srom-timing : array of 7 integers: Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs
> > +
>
> I think these will be optional properties as all Exynos SoC may not be
> having these. So better to add them under "Optional Properties" heading,
> and move this above the "-Example" heading
Not really. Actually 'bank' is not optional, because it actually identifies to which bank properties are applied, and srom-timings
are settings by themselves. Without both of them the definition just doesn't make sense. The only really optional specifier is
'width', which has a default.
Could you give me an example of how to write this correctly?
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
prev parent reply other threads:[~2015-10-27 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 11:47 [PATCH 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pavel Fedin
2015-10-26 11:47 ` [PATCH 1/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin
2015-10-27 2:57 ` Pankaj Dubey
2015-10-26 11:47 ` [PATCH 2/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin
2015-10-26 11:47 ` [PATCH 3/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin
2015-10-27 4:15 ` Pankaj Dubey
2015-10-26 11:47 ` [PATCH 4/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin
2015-10-27 5:11 ` Pankaj Dubey
2015-10-27 6:59 ` Pavel Fedin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00b101d11085$0f9f7be0$2ede73a0$@samsung.com' \
--to=p.fedin@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox