From: pankaj.dubey@samsung•com (Pankaj Dubey)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] Documentation: dt-bindings: Describe SROMc configuration
Date: Tue, 27 Oct 2015 10:41:49 +0530 [thread overview]
Message-ID: <562F0795.10900@samsung.com> (raw)
In-Reply-To: <7ac097efc649bac4e9f2b991baaa969ce4cbc3ef.1445859834.git.p.fedin@samsung.com>
Hi Pavel,
On Monday 26 October 2015 05:17 PM, Pavel Fedin wrote:
> Add documentation for new properties, allowing bank configuration.
>
> Signed-off-by: Pavel Fedin <p.fedin@samsung•com>
> ---
> .../devicetree/bindings/arm/samsung/exynos-srom.txt | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt
> index 33886d5..73750da 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt
> @@ -5,8 +5,25 @@ Required properties:
>
> - reg: offset and length of the register set
>
> -Example:
> +Bank configurations can be defined as an optional subnodes. They can have the
> +following properties:
> +- bank : bank number (0 - 3)
> +- width : data width in bytes (1 or 2). If omitted, default of 1 is used.
> +- srom-timing : array of 7 integers: Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs
> +
I think these will be optional properties as all Exynos SoC may not be
having these. So better to add them under "Optional Properties" heading,
and move this above the "-Example" heading
> +Example: basic definition, no banks are configured
> + sromc at 12570000 {
> + compatible = "samsung,exynos-srom";
> + reg = <0x12570000 0x10>;
> + };
> +
> +Example: SROMc with bank3 configuration
> sromc at 12570000 {
> compatible = "samsung,exynos-srom";
> reg = <0x12570000 0x10>;
> + bank at 3 {
> + bank = <3>;
> + width = <2>;
> + srom-timing = <1 9 12 1 9 1 1>;
> + };
> };
>
Thanks,
Pankaj Dubey
next prev parent reply other threads:[~2015-10-27 5:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 11:47 [PATCH 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410 Pavel Fedin
2015-10-26 11:47 ` [PATCH 1/4] ARM: dts: Add SROMc to Exynos 5410 Pavel Fedin
2015-10-27 2:57 ` Pankaj Dubey
2015-10-26 11:47 ` [PATCH 2/4] drivers: exynos-srom: Add support for bank configuration Pavel Fedin
2015-10-26 11:47 ` [PATCH 3/4] ARM: dts: Add Ethernet chip to SMDK5410 Pavel Fedin
2015-10-27 4:15 ` Pankaj Dubey
2015-10-26 11:47 ` [PATCH 4/4] Documentation: dt-bindings: Describe SROMc configuration Pavel Fedin
2015-10-27 5:11 ` Pankaj Dubey [this message]
2015-10-27 6:59 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562F0795.10900@samsung.com \
--to=pankaj.dubey@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox