From: Petar Stepanovic <pstepanovic@axiado•com>
To: Jonathan Cameron <jic23@kernel•org>,
Joshua Crofts <joshua.crofts1@gmail•com>
Cc: "Akhila Kavi" <akavi@axiado•com>,
"Prasad Bolisetty" <pbolisetty@axiado•com>,
"David Lechner" <dlechner@baylibre•com>,
"Nuno Sá" <nuno.sa@analog•com>,
"Andy Shevchenko" <andy@kernel•org>,
"Rob Herring" <robh@kernel•org>,
"Krzysztof Kozlowski" <krzk+dt@kernel•org>,
"Conor Dooley" <conor+dt@kernel•org>,
"Harshit Shah" <hshah@axiado•com>,
linux-iio@vger•kernel.org, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 2/3] iio: adc: add Axiado SARADC driver
Date: Tue, 2 Jun 2026 12:27:05 +0200 [thread overview]
Message-ID: <0f5b141c-28a2-46e8-b99d-47cfc7632fc8@axiado.com> (raw)
In-Reply-To: <20260528104442.428cce3f@jic23-huawei>
Hi Joshua, Jonathan,
Thanks for the review. I will address the comments in v2.
[inline replies below]
On 5/28/2026 11:44 AM, Jonathan Cameron wrote:
> On Thu, 28 May 2026 11:02:05 +0200
> Joshua Crofts <joshua.crofts1@gmail•com> wrote:
>
>> On Thu, 28 May 2026 at 10:11, Petar Stepanovic <pstepanovic@axiado•com> wrote:
>>> + return 0;
>>> +}
>>> +
>> I don't see any kind of cleanup procedure, like a remove() function
>> or devm_add_action_or_reset callback, is this intentional?
Thanks for pointing this out.
Yes, this was intentional because the driver only enables the ADC during probe,
and all resources are devm-managed.
However, I agree it would be better to explicitly leave the hardware in a safe
state on driver unbind. I will add a devm_add_action_or_reset() callback in v2
to disable the ADC / put it back into power-down state.
Best regards,
Petar
next prev parent reply other threads:[~2026-06-02 10:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 8:10 [PATCH 0/3] Subject: [PATCH 0/3] iio: adc: Add Axiado SARADC driver Petar Stepanovic
2026-05-28 8:10 ` [PATCH 1/3] dt-bindings: iio: adc: add Axiado AX3000/AX3005 SARADC Petar Stepanovic
2026-05-28 9:20 ` Jonathan Cameron
2026-05-28 16:58 ` Conor Dooley
2026-05-28 8:10 ` [PATCH 2/3] iio: adc: add Axiado SARADC driver Petar Stepanovic
2026-05-28 9:02 ` Joshua Crofts
2026-05-28 9:44 ` Jonathan Cameron
2026-06-02 10:27 ` Petar Stepanovic [this message]
2026-05-28 8:10 ` [PATCH 3/3] MAINTAINERS: add Axiado SARADC driver entry Petar Stepanovic
2026-05-28 8:29 ` Joshua Crofts
2026-05-28 9:17 ` [PATCH 0/3] Subject: [PATCH 0/3] iio: adc: Add Axiado SARADC driver Jonathan Cameron
2026-06-03 14:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f5b141c-28a2-46e8-b99d-47cfc7632fc8@axiado.com \
--to=pstepanovic@axiado$(echo .)com \
--cc=akavi@axiado$(echo .)com \
--cc=andy@kernel$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dlechner@baylibre$(echo .)com \
--cc=hshah@axiado$(echo .)com \
--cc=jic23@kernel$(echo .)org \
--cc=joshua.crofts1@gmail$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=nuno.sa@analog$(echo .)com \
--cc=pbolisetty@axiado$(echo .)com \
--cc=robh@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox