From: Jonathan Cameron <jic23@kernel•org>
To: Petar Stepanovic <pstepanovic@axiado•com>
Cc: "Akhila Kavi" <akavi@axiado•com>,
"Prasad Bolisetty" <pbolisetty@axiado•com>,
"David Lechner" <dlechner@baylibre•com>,
"Nuno Sá" <nuno.sa@analog•com>,
"Andy Shevchenko" <andy@kernel•org>,
"Rob Herring" <robh@kernel•org>,
"Krzysztof Kozlowski" <krzk+dt@kernel•org>,
"Conor Dooley" <conor+dt@kernel•org>,
"Harshit Shah" <hshah@axiado•com>,
linux-iio@vger•kernel.org, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iio: adc: add Axiado AX3000/AX3005 SARADC
Date: Thu, 28 May 2026 10:20:40 +0100 [thread overview]
Message-ID: <20260528102034.58fc2486@jic23-huawei> (raw)
In-Reply-To: <20260528-axiado-ax3000-ax3005-saradc-v1-1-345dd5f6608a@axiado.com>
On Thu, 28 May 2026 01:10:23 -0700
Petar Stepanovic <pstepanovic@axiado•com> wrote:
> The Axiado AX3000 and AX3005 SoCs include a 10-bit SAR ADC controller.
> AX3000 supports 16 input channels, while AX3005 supports 8 input
> channels.
>
> Document the compatible strings, register region, clock, reference
> voltage supply, and IIO channel cells.
>
> Signed-off-by: Petar Stepanovic <pstepanovic@axiado•com>
Hi Petar,
One minor thing inline. Otherwise looks good to me.
Thanks,
Jonathan
> ---
> .../bindings/iio/adc/axiado,ax3000-saradc.yaml | 58 ++++++++++++++++++++++
> 1 file changed, 58 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/axiado,ax3000-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/axiado,ax3000-saradc.yaml
> new file mode 100644
> index 000000000000..54592353a7b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/axiado,ax3000-saradc.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/axiado,ax3000-saradc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Axiado AX3000/AX3005 Successive Approximation Register ADC
> +
> +description:
> + The Axiado AX3000/AX3005 SAR ADC is a 10-bit ADC with sixteen input
> + channels on AX3000 and eight input channels on AX3005.
> +
> +maintainers:
> + - Petar Stepanovic <pstepanovic@axiado•com>
> + - Akhila Kavi <akavi@axiado•com>
> + - Prasad Bolisetty <pbolisetty@axiado•com>
> +
> +properties:
> + compatible:
> + enum:
> + - axiado,ax3000-saradc
> + - axiado,ax3005-saradc
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + '#io-channel-cells':
> + const: 1
> +
> + vref-supply:
> + description: Reference voltage regulator supplying the ADC
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - '#io-channel-cells'
> + - vref-supply
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + saradc@806a0000 {
Generic names for nodes in DT. So just adc@806a0000
> + compatible = "axiado,ax3000-saradc";
> + reg = <0x0 0x806a0000 0x0 0x400>;
> + clocks = <&pclk>;
> + vref-supply = <&vref_reg>;
> + #io-channel-cells = <1>;
> + };
> + };
>
next prev parent reply other threads:[~2026-05-28 9:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 8:10 [PATCH 0/3] Subject: [PATCH 0/3] iio: adc: Add Axiado SARADC driver Petar Stepanovic
2026-05-28 8:10 ` [PATCH 1/3] dt-bindings: iio: adc: add Axiado AX3000/AX3005 SARADC Petar Stepanovic
2026-05-28 9:20 ` Jonathan Cameron [this message]
2026-05-28 16:58 ` Conor Dooley
2026-05-28 8:10 ` [PATCH 2/3] iio: adc: add Axiado SARADC driver Petar Stepanovic
2026-05-28 9:02 ` Joshua Crofts
2026-05-28 9:44 ` Jonathan Cameron
2026-06-02 10:27 ` Petar Stepanovic
2026-05-28 8:10 ` [PATCH 3/3] MAINTAINERS: add Axiado SARADC driver entry Petar Stepanovic
2026-05-28 8:29 ` Joshua Crofts
2026-05-28 9:17 ` [PATCH 0/3] Subject: [PATCH 0/3] iio: adc: Add Axiado SARADC driver Jonathan Cameron
2026-06-03 14:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528102034.58fc2486@jic23-huawei \
--to=jic23@kernel$(echo .)org \
--cc=akavi@axiado$(echo .)com \
--cc=andy@kernel$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dlechner@baylibre$(echo .)com \
--cc=hshah@axiado$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=nuno.sa@analog$(echo .)com \
--cc=pbolisetty@axiado$(echo .)com \
--cc=pstepanovic@axiado$(echo .)com \
--cc=robh@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox