From: Lucas Stach <l.stach@pengutronix•de>
To: "Russell King (Oracle)" <linux@armlinux•org.uk>
Cc: linux-arm-kernel@lists•infradead.org, kernel@pengutronix•de,
linux-kernel@vger•kernel.org,
Marco Felsch <m.felsch@pengutronix•de>
Subject: Re: [PATCH] arm: gen-mach-types: don't include absolute filename
Date: Fri, 19 Sep 2025 11:46:59 +0200 [thread overview]
Message-ID: <1159aa58f8a0ab69f9327a98ae3fbb973f6ee36d.camel@pengutronix.de> (raw)
In-Reply-To: <20241114130021.2802803-1-m.felsch@pengutronix.de>
Hi Russell,
can I ask you to kindly reconsider this patch? The generated header
ends up in various packages, not just in compiled form where the
comment wouldn't matter, but also in its raw source code form.
For embedded build systems this mostly affects the debug packages that
carry the full source code. More general purpose distributions like
debian ship this file in the linux-headers package as it's part of the
kapi and they want to allow out-of-tree module builds with the header
package. All those distributions have to jump through various hoops to
make those header packages reproducible, while this patch would be an
easy fix from the kernel side.
I don't think the input file name carries any real value for any of the
users of this header. Especially now where mach-types is essentially
static, with no substantial changes in the last 8 years.
Best regards,
Lucas
Am Donnerstag, dem 14.11.2024 um 14:00 +0100 schrieb Marco Felsch:
> Don't include the abosulte filename into the generated mach-types.h
> header and instead make use of arm64 note. The motivation for this
> change is Yocto emitting a build warning:
>
> > File /usr/src/debug/linux-raspberrypi/6.11.7/arch/arm/include/generated/asm/mach-types.h in package linux-raspberrypi-src contains reference to TMPDIR [buildpaths]
>
> So this change brings us one step closer to make the build result
> reproducible independent of the build path.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix•de>
> ---
> arch/arm/tools/gen-mach-types | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/tools/gen-mach-types b/arch/arm/tools/gen-mach-types
> index cbe1c33bb871..fdc4805b9d98 100644
> --- a/arch/arm/tools/gen-mach-types
> +++ b/arch/arm/tools/gen-mach-types
> @@ -24,8 +24,7 @@ NF == 3 {
>
> END {
> printf("/*\n");
> - printf(" * This was automagically generated from %s!\n", FILENAME);
> - printf(" * Do NOT edit\n");
> + printf(" * Generated file - do not edit\n");
> printf(" */\n\n");
> printf("#ifndef __ASM_ARM_MACH_TYPE_H\n");
> printf("#define __ASM_ARM_MACH_TYPE_H\n\n");
next prev parent reply other threads:[~2025-09-19 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 13:00 [PATCH] arm: gen-mach-types: don't include absolute filename Marco Felsch
2025-09-19 9:46 ` Lucas Stach [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-03 14:12 Sascha Hauer
2026-06-03 15:09 ` Uwe Kleine-König
2026-06-03 18:58 ` Ryan Eatmon
2026-06-04 5:26 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159aa58f8a0ab69f9327a98ae3fbb973f6ee36d.camel@pengutronix.de \
--to=l.stach@pengutronix$(echo .)de \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=m.felsch@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox