public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed

From: Alexander Stein <alexander.stein@ew•tq-group.com>
To: Russell King <linux@armlinux•org.uk>,
	Sascha Hauer <s.hauer@pengutronix•de>
Cc: linux-arm-kernel@lists•infradead.org,
	linux-kernel@vger•kernel.org,
	"Marco Felsch" <m.felsch@pengutronix•de>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre•com>,
	"Ryan Eatmon" <reatmon@ti•com>,
	kernel@pengutronix•de, "Sascha Hauer" <s.hauer@pengutronix•de>
Subject: Re: [PATCH] arm: gen-mach-types: don't include absolute filename
Date: Thu, 04 Jun 2026 07:26:19 +0200	[thread overview]
Message-ID: <11950983.nUPlyArG6x@steina-w> (raw)
In-Reply-To: <20260603-arm-remove-path-from-mach-types-h-v1-1-cda9890ba788@pengutronix.de>

Hi Sascha,

thanks for bringing this up (again).

Am Mittwoch, 3. Juni 2026, 16:12:10 CEST schrieb Sascha Hauer:
> mach-types.h is part of the kapi and as such shipped in the
> linux-headers package. The embedded build path makes that package
> non-reproducible without going through an extra step of normalizing the
> path. YOCTO has similar problems in the kernel debug source package.
> 
> Make the path relative to the kernel source tree which is enough to
> find the tool that has generated the file.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix•de>
> ---
> This topic comes up every once in a while, without any clear objection
> other than "Or just leave it as is. It's in a comment, it doesn't get
> into the executable, and thus is harmless.", from which I am not sure if
> it actually is an objection. Cced the authors of the previous patches
> that I am aware of:
> 
> https://lore.kernel.org/all/20241114130021.2802803-1-m.felsch@pengutronix.de/
> https://lore.kernel.org/all/13360982.O9o76ZdvQC@steina-w/
> https://lore.kernel.org/all/20240213092835.754462-2-u.kleine-koenig@pengutronix.de/
> https://lore.kernel.org/all/20241002175049.15219-1-reatmon@ti.com/

This is much simpler as it hard-codes the file name. I don't have a preference
on that, so
Acked-by: Alexander Stein <alexander.stein@ew•tq-group.com>

Thanks
Alexander

> ---
>  arch/arm/tools/gen-mach-types | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/tools/gen-mach-types b/arch/arm/tools/gen-mach-types
> index cbe1c33bb8710..65ec262b31e65 100644
> --- a/arch/arm/tools/gen-mach-types
> +++ b/arch/arm/tools/gen-mach-types
> @@ -24,7 +24,7 @@ NF == 3 {
>  
>  END	{
>  	  printf("/*\n");
> -	  printf(" * This was automagically generated from %s!\n", FILENAME);
> +	  printf(" * This was automagically generated from arch/arm/tools/gen-mach-types!\n");
>  	  printf(" * Do NOT edit\n");
>  	  printf(" */\n\n");
>  	  printf("#ifndef __ASM_ARM_MACH_TYPE_H\n");
> 
> ---
> base-commit: ba3e43a9e601636f5edb54e259a74f96ca3b8fd8
> change-id: 20260603-arm-remove-path-from-mach-types-h-a6f528d60e00
> 
> Best regards,
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

next prev parent reply	other threads:[~2026-06-04  5:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 14:12 [PATCH] arm: gen-mach-types: don't include absolute filename Sascha Hauer
2026-06-03 15:09 ` Uwe Kleine-König
2026-06-03 18:58   ` Ryan Eatmon
2026-06-04  5:26 ` Alexander Stein [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-11-14 13:00 Marco Felsch
2025-09-19  9:46 ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11950983.nUPlyArG6x@steina-w \
    --to=alexander.stein@ew$(echo .)tq-group.com \
    --cc=kernel@pengutronix$(echo .)de \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux@armlinux$(echo .)org.uk \
    --cc=m.felsch@pengutronix$(echo .)de \
    --cc=reatmon@ti$(echo .)com \
    --cc=s.hauer@pengutronix$(echo .)de \
    --cc=u.kleine-koenig@baylibre$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox