From: t.remmet@phytec•de (Teresa Remmet)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] ARM: dts: Add support for phyCORE-AM335x PCM-953 carrier board
Date: Mon, 23 Jan 2017 11:27:12 +0100 [thread overview]
Message-ID: <1485167232.3082.9.camel@phytec.de> (raw)
In-Reply-To: <20170121205345.oij67ai5d7q7k74d@rob-hp-laptop>
Hello Rob,
Am Samstag, den 21.01.2017, 14:53 -0600 schrieb Rob Herring:
> On Thu, Jan 19, 2017 at 02:07:48PM +0100, Teresa Remmet wrote:
> >
> > The phyCORE-AM335x development kit is a combination of the
> > phyCORE-AM335x SoM and a PCM-953 carrier board. The features
> > of the PCM-953 are:
> > * ETH phy on carrier board: 1x RGMII
> > * 1x CAN
> > * Up to 4x UART
> > * USB0 (otg)
> > * USB1 (host)
> > * SD slot
> > * User gpio-keys
> > * User LEDs
> >
> > Signed-off-by: Teresa Remmet <t.remmet@phytec•de>
> > Reviewed-by: Wadim Egorov <w.egorov@phytec•de>
> > ---
> > ?.../devicetree/bindings/arm/omap/omap.txt??????????|???3 +
> > ?arch/arm/boot/dts/Makefile?????????????????????????|???1 +
> > ?arch/arm/boot/dts/am335x-pcm-953.dtsi??????????????| 303
> > +++++++++++++++++++++
> > ?arch/arm/boot/dts/am335x-phycore-rdk.dts???????????|??27 ++
> > ?4 files changed, 334 insertions(+)
> > ?create mode 100644 arch/arm/boot/dts/am335x-pcm-953.dtsi
> > ?create mode 100644 arch/arm/boot/dts/am335x-phycore-rdk.dts
> [...]
>
> >
> > + user_leds: user_leds {
> > + compatible = "gpio-leds";
> > + };
> > +
> > + user_buttons: user_buttons {
> > + compatible = "gpio-keys";
> > + };
> With only a compatible, I don't think there's much gain to split
> these 2?
> nodes. Otherwse,
whould it be ok to open up the root node again below? Or should I
better move the nodes up? Which does mess up the order then. We
orinented here on the am335x-pepper.dts. They also only keep the
compatibles in the root node.
Thanks,
Teresa
>
> Acked-by: Rob Herring <robh@kernel•org>
>
> >
> > +&user_buttons {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&user_buttons_pins>;
> > + status = "okay";
> > +
> > + button at 0 {
> > + label = "home";
> > + linux,code = <KEY_HOME>;
> > + gpios = <&gpio3 7 GPIO_ACTIVE_HIGH>;
> > + gpio-key,wakeup;
> > + };
> > +
> > + button at 1 {
> > + label = "menu";
> > + linux,code = <KEY_MENU>;
> > + gpios = <&gpio3 8 GPIO_ACTIVE_HIGH>;
> > + gpio-key,wakeup;
> > + };
> > +};
> > +
> > +&user_leds {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&user_leds_pins>;
> > + status = "okay";
> > +
> > + green {
> > + label = "green:user";
> > + gpios = <&gpio1 30 GPIO_ACTIVE_HIGH>;
> > + linux,default-trigger = "gpio";
> > + default-state = "on";
> > + };
> > +
> > + yellow {
> > + label = "yellow:user";
> > + gpios = <&gpio1 31 GPIO_ACTIVE_LOW>;
> > + linux,default-trigger = "gpio";
> > + default-state = "on";
> > + };
> > +};
next prev parent reply other threads:[~2017-01-23 10:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 13:07 [PATCH 1/3] ARM: dts: Add support for phyCORE-AM335x PCM-953 carrier board Teresa Remmet
2017-01-19 13:07 ` [PATCH 2/3] ARM: configs: omap2plus_defconfig: Enable support for micrell phys Teresa Remmet
2017-01-19 13:07 ` [PATCH 3/3] ARM: configs: omap2plus_defconfig: Enable support for RTC M41T80 Teresa Remmet
2017-01-19 14:24 ` [PATCH 1/3] ARM: dts: Add support for phyCORE-AM335x PCM-953 carrier board Vladimir Zapolskiy
2017-01-20 7:36 ` Teresa Remmet
2017-01-21 20:53 ` Rob Herring
2017-01-23 10:27 ` Teresa Remmet [this message]
2017-01-23 14:01 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485167232.3082.9.camel@phytec.de \
--to=t.remmet@phytec$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox