From: robert.richter@amd•com (Robert Richter)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS
Date: Thu, 16 Sep 2010 15:34:44 +0200 [thread overview]
Message-ID: <20100916133444.GB13563@erda.amd.com> (raw)
In-Reply-To: <1284367192.3042.2.camel@e102144-lin.cambridge.arm.com>
On 13.09.10 04:39:52, Will Deacon wrote:
> Hi Matt,
>
> On Mon, 2010-09-13 at 07:07 +0100, Matt Fleming wrote:
> > Currently, oprofile support is only functional if CONFIG_HW_PERF_EVENTS
> > is set. If this symbol is not set, oprofile initialisation will fail at
> > runtime. Instead of allowing the oprofile code to build but fail at
> > runtime it seems less confusing to not allow the code to be built unless
> > hardware performance counter support is available.
> >
> > Signed-off-by: Matt Fleming <matt@console-pimps•org>
> > ---
> > arch/arm/Kconfig | 2 +-
> > arch/arm/oprofile/common.c | 9 ---------
> > 2 files changed, 1 insertions(+), 10 deletions(-)
> When oprofile_arch_init fails (-ENODEV), oprofile will fall back to
> timer mode. With this patch, how can you make use of a timer fallback?
True, if you want an error at compile time, maybe we use the #error
pragma instead. But falling back to timer mode is fine to me too.
Will leave that decision to the arm folks.
-Robert
>
> I'll try and get around to testing the rest of this series today.
>
> Cheers,
>
> Will
>
>
>
>
--
Advanced Micro Devices, Inc.
Operating System Research Center
next prev parent reply other threads:[~2010-09-16 13:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 6:07 [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Matt Fleming
2010-09-13 6:07 ` [PATCH 1/6] perf: Add helper function to return number of counters Matt Fleming
2010-09-16 12:32 ` Robert Richter
2010-09-13 6:07 ` [PATCH 2/6] ARM: oprofile: Rename op_arm to oprofile_perf Matt Fleming
2010-09-16 12:46 ` Robert Richter
2010-09-13 6:07 ` [PATCH 3/6] ARM: oprofile: Move non-ARM code into separate init/exit functions Matt Fleming
2010-09-16 12:55 ` Robert Richter
2010-09-13 6:07 ` [PATCH 4/6] oprofile: Abstract the perf-events backend Matt Fleming
2010-09-16 13:15 ` Robert Richter
2010-09-13 6:07 ` [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS Matt Fleming
2010-09-13 8:39 ` Will Deacon
2010-09-16 13:34 ` Robert Richter [this message]
2010-09-13 9:22 ` Sergei Shtylyov
2010-09-13 6:07 ` [PATCH 6/6] sh: oprofile: Use perf-events oprofile backend Matt Fleming
2010-09-16 14:32 ` Robert Richter
2010-09-27 20:01 ` Matt Fleming
2010-09-27 22:07 ` Robert Richter
2010-09-27 22:26 ` Matt Fleming
2010-09-27 22:45 ` Robert Richter
2010-09-28 8:33 ` Matt Fleming
2010-09-30 1:04 ` Paul Mundt
2010-09-30 8:14 ` Will Deacon
2010-09-13 7:13 ` [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Marc Titinger
2010-09-13 7:50 ` Matt Fleming
2010-09-13 8:51 ` Ingo Molnar
2010-09-13 11:04 ` Matt Fleming
2010-09-13 10:08 ` Will Deacon
2010-09-13 11:18 ` Matt Fleming
2010-09-16 14:48 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916133444.GB13563@erda.amd.com \
--to=robert.richter@amd$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox