From: robert.richter@amd•com (Robert Richter)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile
Date: Thu, 16 Sep 2010 16:48:28 +0200 [thread overview]
Message-ID: <20100916144828.GD13563@erda.amd.com> (raw)
In-Reply-To: <20100913111850.GC14882@console-pimps.org>
On 13.09.10 07:18:50, Matt Fleming wrote:
> On Mon, Sep 13, 2010 at 11:08:53AM +0100, Will Deacon wrote:
> > I've tested this patch series on a multicore Cortex-A9 board. If I
> > revert patch 5/6 (ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS)
> > then everything seems to work fine. Otherwise, testing without
> > HW_PERF_EVENTS doesn't fall back to timer mode.
> >
> > So, with the exception of the patch above:
> >
> > Tested-by: Will Deacon <will.deacon@arm•com>
>
> Hi Will, thanks for testing!
>
> Ah yeah, making oprofile rely on CONFIG_HW_PERF_EVENTS is too
> strict. I hadn't noticed that armpmu_get_pmu_id() is wrapped in
> CONFIG_HW_PERF_EVENTS and had intended op->cpu_type to be NULL and so
> we'd fallback to the timer mode.
>
> This patch needs to be dropped entirely (though another patch should
> conditionally include oprofile_perf.o based on CONFIG_HW_PERF_EVENT
> like I had in my original series).
Matt,
yes, the patch set looks good so far. With the exception of some minor
comments I made and patch #5 dropped, we should be fine. Please update
the patches.
Thanks,
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
prev parent reply other threads:[~2010-09-16 14:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 6:07 [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Matt Fleming
2010-09-13 6:07 ` [PATCH 1/6] perf: Add helper function to return number of counters Matt Fleming
2010-09-16 12:32 ` Robert Richter
2010-09-13 6:07 ` [PATCH 2/6] ARM: oprofile: Rename op_arm to oprofile_perf Matt Fleming
2010-09-16 12:46 ` Robert Richter
2010-09-13 6:07 ` [PATCH 3/6] ARM: oprofile: Move non-ARM code into separate init/exit functions Matt Fleming
2010-09-16 12:55 ` Robert Richter
2010-09-13 6:07 ` [PATCH 4/6] oprofile: Abstract the perf-events backend Matt Fleming
2010-09-16 13:15 ` Robert Richter
2010-09-13 6:07 ` [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS Matt Fleming
2010-09-13 8:39 ` Will Deacon
2010-09-16 13:34 ` Robert Richter
2010-09-13 9:22 ` Sergei Shtylyov
2010-09-13 6:07 ` [PATCH 6/6] sh: oprofile: Use perf-events oprofile backend Matt Fleming
2010-09-16 14:32 ` Robert Richter
2010-09-27 20:01 ` Matt Fleming
2010-09-27 22:07 ` Robert Richter
2010-09-27 22:26 ` Matt Fleming
2010-09-27 22:45 ` Robert Richter
2010-09-28 8:33 ` Matt Fleming
2010-09-30 1:04 ` Paul Mundt
2010-09-30 8:14 ` Will Deacon
2010-09-13 7:13 ` [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Marc Titinger
2010-09-13 7:50 ` Matt Fleming
2010-09-13 8:51 ` Ingo Molnar
2010-09-13 11:04 ` Matt Fleming
2010-09-13 10:08 ` Will Deacon
2010-09-13 11:18 ` Matt Fleming
2010-09-16 14:48 ` Robert Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916144828.GD13563@erda.amd.com \
--to=robert.richter@amd$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox