From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: fix build break due to typo in cacheflush.h
Date: Tue, 21 Sep 2010 09:07:46 -0700 [thread overview]
Message-ID: <20100921160746.GS4611@atomide.com> (raw)
In-Reply-To: <1285085120-29780-1-git-send-email-gadiyar@ti.com>
* Anand Gadiyar <gadiyar@ti•com> [100921 08:57]:
> commit 9d85ac1e6 introduced a small typo. This causes the build
> to break when CONFIG_CPU_V7 is set and CONFIG_CPU_V6 and
> CONFIG_SMP_ON_UP are not. (log below)
>
> CC init/main.o
> In file included from include/linux/highmem.h:9,
> from include/linux/pagemap.h:10,
> from include/linux/mempolicy.h:70,
> from init/main.c:50:
> arch/arm/include/asm/cacheflush.h: In function '__flush_icache_all':
> arch/arm/include/asm/cacheflush.h:332: error: implicit declaration of function '__flush_icache_preferred'
> make[1]: *** [init/main.o] Error 1
> make: *** [init] Error 2
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti•com>
> Cc: Tony Lindgren <tony@atomide•com>
> ---
> arch/arm/include/asm/cacheflush.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-omap-2.6/arch/arm/include/asm/cacheflush.h
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/include/asm/cacheflush.h
> +++ linux-omap-2.6/arch/arm/include/asm/cacheflush.h
> @@ -324,7 +324,7 @@ extern void copy_to_user_page(struct vm_
> #elif __LINUX_ARM_ARCH__ == 6 && defined(CONFIG_ARM_ERRATA_411920)
> #define __flush_icache_preferred __cpuc_flush_icache_all
> #else
> -#define __fluch_icache_preferred __flush_icache_all_generic
> +#define __flush_icache_preferred __flush_icache_all_generic
> #endif
>
> static inline void __flush_icache_all(void)
Thanks, will merge that into the original patch with your S-O-B
and repost.
Tony
prev parent reply other threads:[~2010-09-21 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 16:05 [PATCH] ARM: fix build break due to typo in cacheflush.h Anand Gadiyar
2010-09-21 16:07 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921160746.GS4611@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox