public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
* [PATCH] ARM: fix build break due to typo in cacheflush.h
@ 2010-09-21 16:05 Anand Gadiyar
  2010-09-21 16:07 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Anand Gadiyar @ 2010-09-21 16:05 UTC (permalink / raw)
  To: linux-arm-kernel

commit 9d85ac1e6 introduced a small typo. This causes the build
to break when CONFIG_CPU_V7 is set and CONFIG_CPU_V6 and
CONFIG_SMP_ON_UP are not. (log below)

  CC      init/main.o
In file included from include/linux/highmem.h:9,
                 from include/linux/pagemap.h:10,
                 from include/linux/mempolicy.h:70,
                 from init/main.c:50:
arch/arm/include/asm/cacheflush.h: In function '__flush_icache_all':
arch/arm/include/asm/cacheflush.h:332: error: implicit declaration of function '__flush_icache_preferred'
make[1]: *** [init/main.o] Error 1
make: *** [init] Error 2

Signed-off-by: Anand Gadiyar <gadiyar@ti•com>
Cc: Tony Lindgren <tony@atomide•com>
---
 arch/arm/include/asm/cacheflush.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-omap-2.6/arch/arm/include/asm/cacheflush.h
===================================================================
--- linux-omap-2.6.orig/arch/arm/include/asm/cacheflush.h
+++ linux-omap-2.6/arch/arm/include/asm/cacheflush.h
@@ -324,7 +324,7 @@ extern void copy_to_user_page(struct vm_
 #elif __LINUX_ARM_ARCH__ == 6 && defined(CONFIG_ARM_ERRATA_411920)
 #define __flush_icache_preferred	__cpuc_flush_icache_all
 #else
-#define __fluch_icache_preferred	__flush_icache_all_generic
+#define __flush_icache_preferred	__flush_icache_all_generic
 #endif
 
 static inline void __flush_icache_all(void)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] ARM: fix build break due to typo in cacheflush.h
  2010-09-21 16:05 [PATCH] ARM: fix build break due to typo in cacheflush.h Anand Gadiyar
@ 2010-09-21 16:07 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2010-09-21 16:07 UTC (permalink / raw)
  To: linux-arm-kernel

* Anand Gadiyar <gadiyar@ti•com> [100921 08:57]:
> commit 9d85ac1e6 introduced a small typo. This causes the build
> to break when CONFIG_CPU_V7 is set and CONFIG_CPU_V6 and
> CONFIG_SMP_ON_UP are not. (log below)
> 
>   CC      init/main.o
> In file included from include/linux/highmem.h:9,
>                  from include/linux/pagemap.h:10,
>                  from include/linux/mempolicy.h:70,
>                  from init/main.c:50:
> arch/arm/include/asm/cacheflush.h: In function '__flush_icache_all':
> arch/arm/include/asm/cacheflush.h:332: error: implicit declaration of function '__flush_icache_preferred'
> make[1]: *** [init/main.o] Error 1
> make: *** [init] Error 2
> 
> Signed-off-by: Anand Gadiyar <gadiyar@ti•com>
> Cc: Tony Lindgren <tony@atomide•com>
> ---
>  arch/arm/include/asm/cacheflush.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-omap-2.6/arch/arm/include/asm/cacheflush.h
> ===================================================================
> --- linux-omap-2.6.orig/arch/arm/include/asm/cacheflush.h
> +++ linux-omap-2.6/arch/arm/include/asm/cacheflush.h
> @@ -324,7 +324,7 @@ extern void copy_to_user_page(struct vm_
>  #elif __LINUX_ARM_ARCH__ == 6 && defined(CONFIG_ARM_ERRATA_411920)
>  #define __flush_icache_preferred	__cpuc_flush_icache_all
>  #else
> -#define __fluch_icache_preferred	__flush_icache_all_generic
> +#define __flush_icache_preferred	__flush_icache_all_generic
>  #endif
>  
>  static inline void __flush_icache_all(void)

Thanks, will merge that into the original patch with your S-O-B
and repost.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-21 16:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-21 16:05 [PATCH] ARM: fix build break due to typo in cacheflush.h Anand Gadiyar
2010-09-21 16:07 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox