From: simon@sequanux•org (Simon Guinot)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] hwmon: add generic GPIO fan driver
Date: Wed, 20 Oct 2010 00:19:13 +0000 [thread overview]
Message-ID: <20101020001913.GI29120@kw.sim.vm.gnt> (raw)
In-Reply-To: <1287525825.9690.313.camel@groeck-laptop>
Hi Guenter,
On Tue, Oct 19, 2010 at 03:03:45PM -0700, Guenter Roeck wrote:
> Hi Simon,
>
> one more comment ...
>
> On Sun, 2010-10-17 at 11:50 -0400, Simon Guinot wrote:
> [ ... ]
> > +static int __devinit
> > +fan_alarm_init(struct gpio_fan_data *fan_data, struct gpio_fan_alarm *alarm)
> > +{
>
> __devinit and __devexit can cause problems if this driver is built into
> the kernel, but the underlying i2c master driver is built as module.
I am not sure I understand this. Are you talking about a I2C GPIO
expander ? or about the hwmon registration process ?
For the first case, no I2C mean no GPIOs and the gpio-fan initialization
will fail (because no GPIO chip available). There is nothing wrong with
freeing the useless init functions.
For the second case, let me know...
Not really related, but there is too much __devinit and __devexit
declarations in the first patch version. Thanks to the compiler, all
this functions are inlined in the good place.
>
> So please remove __devinit and __devexit.
I will if you tell me why :)
Thanks,
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101020/f0e121e2/attachment.sig>
next prev parent reply other threads:[~2010-10-20 0:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 10:54 [PATCH 4/5] hwmon: DNS323 rev C1 fan support Benjamin Herrenschmidt
2010-05-22 11:00 ` Benjamin Herrenschmidt
2010-10-13 11:59 ` Simon Guinot
2010-10-13 16:34 ` [lm-sensors] " Guenter Roeck
2010-10-17 15:40 ` Simon Guinot
2010-10-17 15:50 ` [PATCH 1/2] hwmon: add generic GPIO fan driver Simon Guinot
2010-10-17 15:50 ` [PATCH 2/2] [ARM] Kirkwood: add fan support for Network Space Max v2 Simon Guinot
2010-10-22 1:53 ` Guenter Roeck
2010-10-22 2:08 ` Nicolas Pitre
2010-10-22 4:30 ` Guenter Roeck
2010-10-22 9:29 ` [PATCH] " Simon Guinot
2010-10-22 9:59 ` Guenter Roeck
2010-10-22 8:27 ` [PATCH 2/2] " Simon Guinot
2010-10-22 9:58 ` Guenter Roeck
2010-10-22 18:39 ` Guenter Roeck
2010-10-22 18:50 ` Nicolas Pitre
2010-10-18 16:08 ` [PATCH 1/2] hwmon: add generic GPIO fan driver Guenter Roeck
2010-10-18 18:00 ` Chris Moore
2010-10-18 18:35 ` Guenter Roeck
2010-10-18 20:36 ` Simon Guinot
2010-10-18 20:50 ` Guenter Roeck
2010-10-19 11:46 ` Simon Guinot
2010-10-19 14:52 ` Guenter Roeck
2010-10-19 6:52 ` Guenter Roeck
2010-10-19 8:36 ` Simon Guinot
2010-10-19 15:15 ` Guenter Roeck
2010-10-19 19:30 ` Simon Guinot
2010-10-21 20:07 ` Simon Guinot
2010-10-21 20:26 ` Guenter Roeck
2010-10-19 22:03 ` Guenter Roeck
2010-10-20 0:19 ` Simon Guinot [this message]
2010-10-20 0:50 ` Guenter Roeck
2010-10-20 7:59 ` Simon Guinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101020001913.GI29120@kw.sim.vm.gnt \
--to=simon@sequanux$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox