From: moore@free•fr (Chris Moore)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] hwmon: add generic GPIO fan driver
Date: Mon, 18 Oct 2010 20:00:27 +0200 [thread overview]
Message-ID: <4CBC8B3B.8090201@free.fr> (raw)
In-Reply-To: <20101018160830.GB9033@ericsson.com>
Hi,
Le 18/10/2010 18:08, Guenter Roeck a ?crit :
> On Sun, Oct 17, 2010 at 11:50:11AM -0400, Simon Guinot wrote:
>
>> +static void __set_fan_ctrl(struct gpio_fan_data *fan_data, int ctrl_val)
>> +{
>> + int i;
>> +
>> + for (i = 0; i< fan_data->num_ctrl; i++) {
>> + int value = !!(ctrl_val& (1<< i));
>> +
> value = (ctrl_val& (1>> i));
> would be much simpler and easier to understand.
IMHO you mean:
value = (ctrl_val>> i)& 1;
Cheers,
Chris
next prev parent reply other threads:[~2010-10-18 18:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 10:54 [PATCH 4/5] hwmon: DNS323 rev C1 fan support Benjamin Herrenschmidt
2010-05-22 11:00 ` Benjamin Herrenschmidt
2010-10-13 11:59 ` Simon Guinot
2010-10-13 16:34 ` [lm-sensors] " Guenter Roeck
2010-10-17 15:40 ` Simon Guinot
2010-10-17 15:50 ` [PATCH 1/2] hwmon: add generic GPIO fan driver Simon Guinot
2010-10-17 15:50 ` [PATCH 2/2] [ARM] Kirkwood: add fan support for Network Space Max v2 Simon Guinot
2010-10-22 1:53 ` Guenter Roeck
2010-10-22 2:08 ` Nicolas Pitre
2010-10-22 4:30 ` Guenter Roeck
2010-10-22 9:29 ` [PATCH] " Simon Guinot
2010-10-22 9:59 ` Guenter Roeck
2010-10-22 8:27 ` [PATCH 2/2] " Simon Guinot
2010-10-22 9:58 ` Guenter Roeck
2010-10-22 18:39 ` Guenter Roeck
2010-10-22 18:50 ` Nicolas Pitre
2010-10-18 16:08 ` [PATCH 1/2] hwmon: add generic GPIO fan driver Guenter Roeck
2010-10-18 18:00 ` Chris Moore [this message]
2010-10-18 18:35 ` Guenter Roeck
2010-10-18 20:36 ` Simon Guinot
2010-10-18 20:50 ` Guenter Roeck
2010-10-19 11:46 ` Simon Guinot
2010-10-19 14:52 ` Guenter Roeck
2010-10-19 6:52 ` Guenter Roeck
2010-10-19 8:36 ` Simon Guinot
2010-10-19 15:15 ` Guenter Roeck
2010-10-19 19:30 ` Simon Guinot
2010-10-21 20:07 ` Simon Guinot
2010-10-21 20:26 ` Guenter Roeck
2010-10-19 22:03 ` Guenter Roeck
2010-10-20 0:19 ` Simon Guinot
2010-10-20 0:50 ` Guenter Roeck
2010-10-20 7:59 ` Simon Guinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBC8B3B.8090201@free.fr \
--to=moore@free$(echo .)fr \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox