From: dave.martin@linaro•org (Dave Martin)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: vexpress: initial device tree support
Date: Wed, 21 Sep 2011 16:49:39 +0100 [thread overview]
Message-ID: <20110921154939.GF2872@arm.com> (raw)
In-Reply-To: <1316615590.4611.624.camel@hornet.cambridge.arm.com>
On Wed, Sep 21, 2011 at 03:33:10PM +0100, Pawel Moll wrote:
> > OK, I'll try to propose documentation for these:
> > * arm,pl180
>
> You can skip this one - I'll add the description together with the MMCI
> driver bindings (it will be 180 and 181, by the way :-)
Done.
> > > > + // Timer init is hardcoded in v2m_timer_init(), for now.
> > > > + // timer at 11000 {
> > > > + // compatible = "arm,arm-sp804";
> > >
> > > arm,sp804 is more consistent. I believe the sp804 does have the periphid
> > > registers, so arm,primecell should also be added.
> >
> > Do you mean "does not have"? If so, the periphid will be needed -- thanks for
> > pointing it out in that case.
>
> I think Rob meant it should be
> compatible = "arm,sp804", "arm,primecell",
> as SP804 contains the PrimeCell periphid registers, so will be
> recognized by amba bus driver.
Oh, right -- misunderstanding, sorry for that.
> > I will make the names consistent. These were pasted from someone Lorenzo's
> > older patches, and failed to sport e the inconsistency since I wasn't
> > actually making use of these entries yet.
> >
> > > > + // reg = <0x11000 0x1000>;
> > > > + // interrupts = <2>;
> > > > + // };
> > > > +
> > > > + // timer at 12000 {
> > > > + // compatible = "arm,arm-sp804";
> > > > + // reg = <0x12000 0x1000>;
> > > > + // };
> > >
> > > Just because Linux is not using it, doesn't mean you should comment it out.
> >
> > From the point of view of describing the hardware, yes. However, I was
> > a bit worried that if sp804 is turned into a full driver, it will get
> > initialised twice -- once explicitly and once in of_platform_populate()...
> > at least until the baord code is adapted to work properly with the new
> > driver.
> >
> > Commenting these entries out for now seemed a good idea to avoid the flag-day
> > hazard. Am I being too cautious?
>
> I think you are ;-) Besides my static-mapping-rework is already using
> those...
OK, I will uncomment it then.
Cheers
---Dave
next prev parent reply other threads:[~2011-09-21 15:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 9:19 [PATCH] ARM: vexpress: initial device tree support Dave Martin
2011-09-21 13:24 ` Rob Herring
2011-09-21 14:24 ` Dave Martin
2011-09-21 14:33 ` Pawel Moll
2011-09-21 15:49 ` Dave Martin [this message]
2011-09-21 14:57 ` Grant Likely
2011-09-21 16:01 ` Pawel Moll
2011-09-21 16:17 ` Dave Martin
2011-09-21 16:28 ` Pawel Moll
2011-09-21 16:37 ` Rob Herring
2011-09-21 17:15 ` Dave Martin
2011-09-21 17:47 ` Mitch Bradley
2011-09-22 12:19 ` Dave Martin
2012-01-09 23:26 ` Tabi Timur-B04825
2012-01-10 0:42 ` Mitch Bradley
2012-01-10 2:24 ` Tabi Timur-B04825
2012-01-10 12:22 ` Jamie Lokier
2012-01-10 21:58 ` Timur Tabi
2012-01-10 22:35 ` Mitch Bradley
2012-01-10 23:55 ` Stephen Warren
2012-01-11 0:02 ` Timur Tabi
2012-01-11 0:28 ` Timur Tabi
2012-01-11 6:43 ` Mitch Bradley
2012-01-11 20:17 ` Timur Tabi
2012-01-11 23:20 ` Mitch Bradley
2012-01-11 23:32 ` Timur Tabi
2012-01-11 20:29 ` Stephen Warren
2012-01-11 20:32 ` Timur Tabi
2012-01-11 20:36 ` Stephen Warren
2012-01-11 21:37 ` Timur Tabi
2012-01-11 21:57 ` Stephen Warren
2012-01-12 12:24 ` Jamie Lokier
2012-01-12 16:49 ` Stephen Warren
2012-01-11 23:16 ` Mitch Bradley
2012-01-12 0:15 ` Stephen Warren
2012-01-12 0:38 ` Mitch Bradley
2012-01-12 0:47 ` Mitch Bradley
2012-01-12 16:45 ` Stephen Warren
2012-01-12 12:09 ` Jamie Lokier
2012-01-12 16:52 ` Stephen Warren
2012-01-10 11:04 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110921154939.GF2872@arm.com \
--to=dave.martin@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox