From: plagnioj@jcrosoft•com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/7] at91 : pm.h cleanups
Date: Mon, 23 Jan 2012 07:29:00 +0100 [thread overview]
Message-ID: <20120123062900.GP25622@game.jcrosoft.org> (raw)
In-Reply-To: <201201111523.57368.arnd.bergmann@linaro.org>
On 15:23 Wed 11 Jan , Arnd Bergmann wrote:
> On Wednesday 11 January 2012, Daniel Lezcano wrote:
> >
> > This patchset is the first series to cleanup some code around pm.h, pm.c and
> > cpuidle. The next series will bring more cleanups and finally the third series
> > will change the different functions into ops where we can export the structure
> > definition in order to encapsulate the code and move the at91's cpuidle driver
> > to the drivers/cpuidle directory.
>
> Hi Daniel,
>
> These all look like useful cleanups. You don't really have to split them
> up into so small units, but it doesn't hurt if you do. Patch 5 seems to
> actually fix a bug, but probably a harmless one.
>
> It's not clear where you're headed though, I hope that becomes more obvious
> in the next patches. The tricky bit that will have to be done is to turn
> all the #ifdef checks into runtime here. You have moved the #include for the
> memory controller into a new header, but that is not actually progress
> on this larger problem. It would be nice to move the
> sdram_selfrefresh_enable/disable functions into a .c file that uses
> cpu_is_at91...() to do runtime detection, but AFAICT that won't work
> because you have to guarantee that all the code between these is
> in the cache, right?
we may have much simple way move it to sram as done in slow clock
Best Regards,
J.
next prev parent reply other threads:[~2012-01-23 6:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 14:55 [PATCH 0/7] at91 : pm.h cleanups Daniel Lezcano
2012-01-11 14:55 ` [PATCH 1/7] at91 : coding style fixes Daniel Lezcano
2012-01-11 14:55 ` [PATCH 2/7] at91 : declare header name Daniel Lezcano
2012-01-11 14:55 ` [PATCH 3/7] at91 : group headers inclusion for the memory controller Daniel Lezcano
2012-01-11 14:55 ` [PATCH 4/7] at91 : convert pm.h macros to static inline functions Daniel Lezcano
2012-01-11 14:55 ` [PATCH 5/7] at91 : fix dirty hack for the selfrefresh function Daniel Lezcano
2012-01-11 15:10 ` Arnd Bergmann
2012-01-11 16:55 ` Russell King - ARM Linux
2012-01-11 18:27 ` Arnd Bergmann
2012-01-11 19:43 ` Russell King - ARM Linux
2012-01-12 14:41 ` Nicolas Ferre
2012-01-12 19:36 ` Russell King - ARM Linux
2012-01-13 0:38 ` Rob Lee
2012-01-13 9:29 ` Daniel Lezcano
2012-01-13 10:22 ` Russell King - ARM Linux
2012-01-13 15:48 ` Arnd Bergmann
2012-01-13 17:25 ` Rob Lee
2012-01-11 14:55 ` [PATCH 6/7] at91 : group selfrefresh functions Daniel Lezcano
2012-01-11 16:56 ` Russell King - ARM Linux
2012-01-11 14:55 ` [PATCH 7/7] at91 : fix compilation warning Daniel Lezcano
2012-01-11 15:23 ` [PATCH 0/7] at91 : pm.h cleanups Arnd Bergmann
2012-01-11 16:29 ` Daniel Lezcano
2012-01-23 6:29 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-01-11 16:57 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123062900.GP25622@game.jcrosoft.org \
--to=plagnioj@jcrosoft$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox