From: daniel.lezcano@linaro•org (Daniel Lezcano)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/7] at91 : fix dirty hack for the selfrefresh function
Date: Fri, 13 Jan 2012 10:29:49 +0100 [thread overview]
Message-ID: <4F0FF98D.9050308@linaro.org> (raw)
In-Reply-To: <CAMXH7KEX+pMZvSnb5HHuMFaPbupSx+qCJkGtoDLTDkaboHCoMQ@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/13/2012 01:38 AM, Rob Lee wrote:
> On Thu, Jan 12, 2012 at 1:36 PM, Russell King - ARM Linux
> <linux@arm•linux.org.uk> wrote:
>
>> Okay, that makes sense (because everything but rm9200 branches out to
>> one of the cpu idle functions.)
>>
>> It also supports my second idea described in
>> http://lists.arm.linux.org.uk/lurker/message/20120109.144443.3626e5a6.en.html
>> See the paragraph starting "So, what I suggest instead" at that URL and
>> following text.
>>
>> The reason I think this is the best solution is:
>> (a) we move the CPU dependencies into each CPU file
>> (b) we localize the quirks needed for each CPU into its own specific code
>> (c) we can select at run time between the various standby functions
>>
>> These are all AT91 specific wins. What it also gets us is _much_ less
>> exported code from arch/arm/mach-at91 when the CPU idle stuff moves out,
>> reducing it down to just a mere function pointer, and, because the AT91
>> specific idle stuff is hidden behind this it potentially opens the door
>> towards some consolidation in this area between different SoCs.
>
> Apologies if this is a dumb question, but for the arch/arm/mach-at91
> function pointer that needs to be exported, what is the recommended
> method for exporting it to a file that needs it in drivers/cpuidle?
I was asking me the same question. I am wondering if that makes sense to
create an arch/arm/include/asm/pm.h file where we move from the system.h
file these two functions:
extern void (*arm_pm_restart)(char str, const char *cmd);
extern void (*arm_pm_idle)(void);
and we add:
extern void (*arm_pm_standby)(void);
- --
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJPD/mNAAoJEAKBbMCpUGYAHFAH/0yXlX49BUW1nDqZPiP777tc
rEajf5vD2lvvDzF3aeqmwfxLhNKBkppeasxFX8KCukQGq4SmDgC34NSbHAKi3SqX
/Yv3xcWEPqnp3PgPacNCFX7kGqHIr9XWHjG/p38+82rGCOgtWn0DslOuzFa5JlJu
ih2Yh+2hh2low4h/21no8rF08EJefh0PuMn1c58Jg04txe8iATpXZHU9ujeIlvUg
NdHr8q1gzfGsnFb1gV26NHapERLwCJlj2ilttYMnNyHZYxTssDrnI4HsMDcyjcEQ
0BQYV0VMAHGSPiv9AIMx0ykCwQrjuDZPBEJIFS0ReZ1ItcGwVFFEmqb9X+OdJdg=
=g+rR
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-01-13 9:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 14:55 [PATCH 0/7] at91 : pm.h cleanups Daniel Lezcano
2012-01-11 14:55 ` [PATCH 1/7] at91 : coding style fixes Daniel Lezcano
2012-01-11 14:55 ` [PATCH 2/7] at91 : declare header name Daniel Lezcano
2012-01-11 14:55 ` [PATCH 3/7] at91 : group headers inclusion for the memory controller Daniel Lezcano
2012-01-11 14:55 ` [PATCH 4/7] at91 : convert pm.h macros to static inline functions Daniel Lezcano
2012-01-11 14:55 ` [PATCH 5/7] at91 : fix dirty hack for the selfrefresh function Daniel Lezcano
2012-01-11 15:10 ` Arnd Bergmann
2012-01-11 16:55 ` Russell King - ARM Linux
2012-01-11 18:27 ` Arnd Bergmann
2012-01-11 19:43 ` Russell King - ARM Linux
2012-01-12 14:41 ` Nicolas Ferre
2012-01-12 19:36 ` Russell King - ARM Linux
2012-01-13 0:38 ` Rob Lee
2012-01-13 9:29 ` Daniel Lezcano [this message]
2012-01-13 10:22 ` Russell King - ARM Linux
2012-01-13 15:48 ` Arnd Bergmann
2012-01-13 17:25 ` Rob Lee
2012-01-11 14:55 ` [PATCH 6/7] at91 : group selfrefresh functions Daniel Lezcano
2012-01-11 16:56 ` Russell King - ARM Linux
2012-01-11 14:55 ` [PATCH 7/7] at91 : fix compilation warning Daniel Lezcano
2012-01-11 15:23 ` [PATCH 0/7] at91 : pm.h cleanups Arnd Bergmann
2012-01-11 16:29 ` Daniel Lezcano
2012-01-23 6:29 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-11 16:57 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0FF98D.9050308@linaro.org \
--to=daniel.lezcano@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox