From: marex@denx•de (Marek Vasut)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 5/8] MXS: Add USB PHY driver
Date: Wed, 16 May 2012 15:37:21 +0200 [thread overview]
Message-ID: <201205161537.21382.marex@denx.de> (raw)
In-Reply-To: <20120516103529.GC22251@nchen-desktop>
Dear Peter Chen,
> On Tue, May 15, 2012 at 10:23:36AM +0200, Marek Vasut wrote:
> > Add driver that controls the built-in USB PHY in the i.MX233/i.MX28. This
> > enables the PHY upon powerup and shuts it down on shutdown.
>
> Please add i.mx6q .
>
> > +config USB_MXS_PHY
> > + tristate "Freescale i.MX28 USB PHY support"
> > + select USB_OTG_UTILS
> > + select USB_IMX_COMPOSITE
>
> Seems you will not use imx_otg.c with chipidea framework.
Good catch :)
>
> > + *
> > + * Freescale i.MX28 USB PHY driver.
>
> use mxs
Now ... I think we have two waring opinions in here :)
> > + *
> > +
> > + /* Enable FS/LS compatibility and wakeup IRQs. */
> > + val = BM_USBPHY_CTRL_ENUTMILEVEL2 | BM_USBPHY_CTRL_ENUTMILEVEL3 |
> > + BM_USBPHY_CTRL_ENIRQWAKEUP;
> > +
> > + /* Enable IRQ sources. */
> > + val |= BM_USBPHY_CTRL_ENIDCHG_WKUP | BM_USBPHY_CTRL_ENDPDMCHG_WKUP |
> > + BM_USBPHY_CTRL_ENVBUSCHG_WKUP;
>
> Please forget wakeup function currently, as it will make things more
> complicated.
>
> > +
> > + writel(val, x->io_priv + HW_USBPHY_CTRL_SET);
> > +
> > + return 0;
> > +}
> > +
> > + /* Disable FS/LS compatibility and wakeup IRQs. */
> > + val = BM_USBPHY_CTRL_ENUTMILEVEL2 | BM_USBPHY_CTRL_ENUTMILEVEL3 |
> > + BM_USBPHY_CTRL_ENIRQWAKEUP;
> > +
> > + /* Disable IRQ sources. */
> > + val |= BM_USBPHY_CTRL_ENIDCHG_WKUP | BM_USBPHY_CTRL_ENDPDMCHG_WKUP |
> > + BM_USBPHY_CTRL_ENVBUSCHG_WKUP;
> > +
>
> The same with above
>
> > +
> > +MODULE_ALIAS("platform:mxs-usb-phy");
> > +MODULE_AUTHOR("Marek Vasut <marex@denx•de>");
> > +MODULE_DESCRIPTION("Freescale i.MX28 USB PHY driver");
>
> mxs
>
> > +MODULE_LICENSE("GPL");
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-16 13:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 8:23 [RFC PATCH 0/8 V8] MXS: Add i.MX28 USB Host driver Marek Vasut
2012-05-15 8:23 ` [PATCH 1/8] MXS: Make clk_disable return integer Marek Vasut
2012-05-16 0:55 ` Richard Zhao
2012-05-16 1:01 ` Marek Vasut
2012-05-15 8:23 ` [PATCH 2/8] MXS: Add USB EHCI and USB PHY clock handling Marek Vasut
2012-05-16 0:56 ` Richard Zhao
2012-05-15 8:23 ` [PATCH 3/8] MXS: Fixup i.MX233 USB base address name Marek Vasut
2012-05-16 0:58 ` Richard Zhao
2012-05-16 1:02 ` Marek Vasut
2012-05-15 8:23 ` [PATCH 4/8] MXS: Add data shared between imx-otg and EHCI driver Marek Vasut
2012-05-16 1:00 ` Richard Zhao
2012-05-15 8:23 ` [PATCH 5/8] MXS: Add USB PHY driver Marek Vasut
2012-05-16 3:33 ` Richard Zhao
2012-05-16 4:30 ` Marek Vasut
2012-05-16 5:06 ` Richard Zhao
2012-05-16 7:18 ` Richard Zhao
2012-05-16 13:36 ` Marek Vasut
2012-05-16 13:35 ` Marek Vasut
2012-05-16 10:35 ` Peter Chen
2012-05-16 13:37 ` Marek Vasut [this message]
2012-05-15 8:23 ` [PATCH 6/8] CI13xxx: Add i.MX233/i.MX28 binding code Marek Vasut
2012-05-16 8:36 ` Felipe Balbi
2012-05-16 13:41 ` Marek Vasut
2012-05-18 11:34 ` Felipe Balbi
2012-05-15 8:23 ` [PATCH 7/8] MXS: Add platform registration hooks for USB EHCI Marek Vasut
2012-05-15 8:23 ` [PATCH 8/8] MXS: Enable USB on M28EVK Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2012-04-17 10:15 [RFC PATCH 0/8] MXS: Add i.MX28 USB Host driver Marek Vasut
2012-04-17 10:15 ` [PATCH 5/8] MXS: Add USB PHY driver Marek Vasut
2012-04-17 17:51 ` Sascha Hauer
2012-04-19 11:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205161537.21382.marex@denx.de \
--to=marex@denx$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox