From: gregkh@linuxfoundation•org (Greg KH)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] printk: Fix alignment of buf causing crash on ARM EABI
Date: Tue, 5 Jun 2012 15:59:18 +0900 [thread overview]
Message-ID: <20120605065918.GA17674@kroah.com> (raw)
In-Reply-To: <1338879154-6546-1-git-send-email-andrew@lunn.ch>
On Tue, Jun 05, 2012 at 08:52:34AM +0200, Andrew Lunn wrote:
> Commit 7ff9554bb578ba02166071d2d487b7fc7d860d62, printk: convert
> byte-buffer to variable-length record buffer, causes systems using
> EABI to crash very early in the boot cycle. The first entry in struct
> log is a u64, which for EABI must be 8 byte aligned.
>
> Make use of __alignof__() so the compiler to decide the alignment, but
> allow it to be overridden using CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS,
> for systems which can perform unaligned access and want to save
> a few bytes of space.
>
> Tested on Orion5x and Kirkwood.
>
> Signed-off-by: Andrew Lunn <andrew@lunn•ch>
> ---
> kernel/printk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, I think I have a patch in my to-apply queue that fixes this in a
bit different way. I'll dig that up and compare them in the next few
days as I work my way through my pending patch queue.
greg k-h
next prev parent reply other threads:[~2012-06-05 6:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 6:52 [PATCH] printk: Fix alignment of buf causing crash on ARM EABI Andrew Lunn
2012-06-05 6:59 ` Greg KH [this message]
2012-06-05 14:20 ` Kay Sievers
2012-06-05 16:03 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120605065918.GA17674@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox