From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] printk: Fix alignment of buf causing crash on ARM EABI
Date: Tue, 05 Jun 2012 10:03:09 -0600 [thread overview]
Message-ID: <4FCE2DBD.9030609@wwwdotorg.org> (raw)
In-Reply-To: <1338879154-6546-1-git-send-email-andrew@lunn.ch>
On 06/05/2012 12:52 AM, Andrew Lunn wrote:
> Commit 7ff9554bb578ba02166071d2d487b7fc7d860d62, printk: convert
> byte-buffer to variable-length record buffer, causes systems using
> EABI to crash very early in the boot cycle. The first entry in struct
> log is a u64, which for EABI must be 8 byte aligned.
>
> Make use of __alignof__() so the compiler to decide the alignment, but
> allow it to be overridden using CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS,
> for systems which can perform unaligned access and want to save
> a few bytes of space.
>
> Tested on Orion5x and Kirkwood.
>
> Signed-off-by: Andrew Lunn <andrew@lunn•ch>
Tested-by: Stephen Warren <swarren@wwwdotorg•org>
Acked-by: Stephen Warren <swarren@wwwdotorg•org>
Indeed, using alignof is a good idea.
prev parent reply other threads:[~2012-06-05 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 6:52 [PATCH] printk: Fix alignment of buf causing crash on ARM EABI Andrew Lunn
2012-06-05 6:59 ` Greg KH
2012-06-05 14:20 ` Kay Sievers
2012-06-05 16:03 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCE2DBD.9030609@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox