From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support
Date: Thu, 19 Jul 2012 04:40:02 -0700 [thread overview]
Message-ID: <20120719114001.GO6522@atomide.com> (raw)
In-Reply-To: <CABxcv=nbUOKKhJxTG302fX=UzHsX3mN=R2nEi88VZM61ka11Vg@mail.gmail.com>
* Javier Martinez Canillas <javier@dowhile0•org> [120716 16:33]:
> On Mon, Jul 16, 2012 at 7:12 PM, Kevin Hilman <khilman@ti•com> wrote:
> > Javier Martinez Canillas <javier@dowhile0•org> writes:
> >
> >> commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775
> >> Author: Russell King <rmk+kernel@arm•linux.org.uk>
> >> Date: Sat Apr 21 22:41:10 2012 +0100
> >>
> >> mmc: omap: remove private DMA API implementation
> >>
> >> removed the private DMA API implementation from the OMAP mmc host to
> >> make it use exclusively the DMA engine API.
> >>
> >> Unfortunately the omap2plus_defconfig doesn't enable this feature
> >> leading to the following error on an IGEPv2 Rev.C (and probably on most
> >> boards with MMC support):
> >
> > Personally, I'd rather see this fixed by having the drivers that depend
> > on DMA engine 'select DMADEVICES'. That way, any defconfig will work
> > correctly instead of just omap2plus_defconfig.
> >
> > Kevin
> >
>
> Hi Kevin,
>
> Thanks a lot for your feedback. I'll do what you suggest and send a v2
> of the patch.
I'd rather see the drivers fixed to work with and without DMA as the
channels can run out. Also forcing the select is not good for distro kernels.
I'll apply this fix into l-o master branch while we're discussing the
issue.
Regards,
Tony
prev parent reply other threads:[~2012-07-19 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-15 3:03 [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support Javier Martinez Canillas
2012-07-16 17:12 ` Kevin Hilman
2012-07-16 23:28 ` Javier Martinez Canillas
2012-07-19 11:40 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120719114001.GO6522@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox