* [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support
@ 2012-07-15 3:03 Javier Martinez Canillas
2012-07-16 17:12 ` Kevin Hilman
0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2012-07-15 3:03 UTC (permalink / raw)
To: linux-arm-kernel
commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775
Author: Russell King <rmk+kernel@arm•linux.org.uk>
Date: Sat Apr 21 22:41:10 2012 +0100
mmc: omap: remove private DMA API implementation
removed the private DMA API implementation from the OMAP mmc host to
make it use exclusively the DMA engine API.
Unfortunately the omap2plus_defconfig doesn't enable this feature
leading to the following error on an IGEPv2 Rev.C (and probably on most
boards with MMC support):
[ 2.199981] omap_hsmmc omap_hsmmc.1: unable to obtain RX DMA engine channel 48
[ 2.215087] omap_hsmmc omap_hsmmc.0: unable to obtain RX DMA engine channel 62
Signed-off-by: Javier Martinez Canillas <javier@dowhile0•org>
---
arch/arm/configs/omap2plus_defconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index b152de7..e58edc3 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -193,6 +193,8 @@ CONFIG_MMC_OMAP_HS=y
CONFIG_RTC_CLASS=y
CONFIG_RTC_DRV_TWL92330=y
CONFIG_RTC_DRV_TWL4030=y
+CONFIG_DMADEVICES=y
+CONFIG_DMA_OMAP=y
CONFIG_EXT2_FS=y
CONFIG_EXT3_FS=y
# CONFIG_EXT3_FS_XATTR is not set
--
1.7.7.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support
2012-07-15 3:03 [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support Javier Martinez Canillas
@ 2012-07-16 17:12 ` Kevin Hilman
2012-07-16 23:28 ` Javier Martinez Canillas
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Hilman @ 2012-07-16 17:12 UTC (permalink / raw)
To: linux-arm-kernel
Javier Martinez Canillas <javier@dowhile0•org> writes:
> commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775
> Author: Russell King <rmk+kernel@arm•linux.org.uk>
> Date: Sat Apr 21 22:41:10 2012 +0100
>
> mmc: omap: remove private DMA API implementation
>
> removed the private DMA API implementation from the OMAP mmc host to
> make it use exclusively the DMA engine API.
>
> Unfortunately the omap2plus_defconfig doesn't enable this feature
> leading to the following error on an IGEPv2 Rev.C (and probably on most
> boards with MMC support):
Personally, I'd rather see this fixed by having the drivers that depend
on DMA engine 'select DMADEVICES'. That way, any defconfig will work
correctly instead of just omap2plus_defconfig.
Kevin
> [ 2.199981] omap_hsmmc omap_hsmmc.1: unable to obtain RX DMA engine channel 48
> [ 2.215087] omap_hsmmc omap_hsmmc.0: unable to obtain RX DMA engine channel 62
>
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0•org>
> ---
> arch/arm/configs/omap2plus_defconfig | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index b152de7..e58edc3 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -193,6 +193,8 @@ CONFIG_MMC_OMAP_HS=y
> CONFIG_RTC_CLASS=y
> CONFIG_RTC_DRV_TWL92330=y
> CONFIG_RTC_DRV_TWL4030=y
> +CONFIG_DMADEVICES=y
> +CONFIG_DMA_OMAP=y
> CONFIG_EXT2_FS=y
> CONFIG_EXT3_FS=y
> # CONFIG_EXT3_FS_XATTR is not set
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support
2012-07-16 17:12 ` Kevin Hilman
@ 2012-07-16 23:28 ` Javier Martinez Canillas
2012-07-19 11:40 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2012-07-16 23:28 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 16, 2012 at 7:12 PM, Kevin Hilman <khilman@ti•com> wrote:
> Javier Martinez Canillas <javier@dowhile0•org> writes:
>
>> commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775
>> Author: Russell King <rmk+kernel@arm•linux.org.uk>
>> Date: Sat Apr 21 22:41:10 2012 +0100
>>
>> mmc: omap: remove private DMA API implementation
>>
>> removed the private DMA API implementation from the OMAP mmc host to
>> make it use exclusively the DMA engine API.
>>
>> Unfortunately the omap2plus_defconfig doesn't enable this feature
>> leading to the following error on an IGEPv2 Rev.C (and probably on most
>> boards with MMC support):
>
> Personally, I'd rather see this fixed by having the drivers that depend
> on DMA engine 'select DMADEVICES'. That way, any defconfig will work
> correctly instead of just omap2plus_defconfig.
>
> Kevin
>
Hi Kevin,
Thanks a lot for your feedback. I'll do what you suggest and send a v2
of the patch.
Best regards,
Javier
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support
2012-07-16 23:28 ` Javier Martinez Canillas
@ 2012-07-19 11:40 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-07-19 11:40 UTC (permalink / raw)
To: linux-arm-kernel
* Javier Martinez Canillas <javier@dowhile0•org> [120716 16:33]:
> On Mon, Jul 16, 2012 at 7:12 PM, Kevin Hilman <khilman@ti•com> wrote:
> > Javier Martinez Canillas <javier@dowhile0•org> writes:
> >
> >> commit 13f30fc893e4610f67dd7a8b0b67aec02eac1775
> >> Author: Russell King <rmk+kernel@arm•linux.org.uk>
> >> Date: Sat Apr 21 22:41:10 2012 +0100
> >>
> >> mmc: omap: remove private DMA API implementation
> >>
> >> removed the private DMA API implementation from the OMAP mmc host to
> >> make it use exclusively the DMA engine API.
> >>
> >> Unfortunately the omap2plus_defconfig doesn't enable this feature
> >> leading to the following error on an IGEPv2 Rev.C (and probably on most
> >> boards with MMC support):
> >
> > Personally, I'd rather see this fixed by having the drivers that depend
> > on DMA engine 'select DMADEVICES'. That way, any defconfig will work
> > correctly instead of just omap2plus_defconfig.
> >
> > Kevin
> >
>
> Hi Kevin,
>
> Thanks a lot for your feedback. I'll do what you suggest and send a v2
> of the patch.
I'd rather see the drivers fixed to work with and without DMA as the
channels can run out. Also forcing the select is not good for distro kernels.
I'll apply this fix into l-o master branch while we're discussing the
issue.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-19 11:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-15 3:03 [PATCH 1/1] ARM: OMAP2+: omap2plus_defconfig: enable OMAP DMA engine support Javier Martinez Canillas
2012-07-16 17:12 ` Kevin Hilman
2012-07-16 23:28 ` Javier Martinez Canillas
2012-07-19 11:40 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox