From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] gpio: Add simple poweroff-gpio driver
Date: Mon, 12 Nov 2012 09:25:46 +0100 [thread overview]
Message-ID: <20121112082546.GU22029@lunn.ch> (raw)
In-Reply-To: <50A020C5.4070506@wwwdotorg.org>
On Sun, Nov 11, 2012 at 03:03:49PM -0700, Stephen Warren wrote:
> On 11/11/2012 09:21 AM, Andrew Lunn wrote:
> > From: Jamie Lentin <jm@lentin•co.uk>
> >
> > Given appropriate devicetree bindings, this driver registers a
> > pm_power_off function to set a GPIO line high/low to power down
> > your board.
>
> This feature will be useful for the Tegra TrimSlice board too.
Hi Stephen
Great to hear its usable for others.
> > diff --git a/Documentation/devicetree/bindings/gpio/gpio-poweroff.txt b/Documentation/devicetree/bindings/gpio/gpio-poweroff.txt
>
> > +Required properties:
> > +- compatible : should be "gpio-poweroff".
> > +- gpios : The GPIO to set high/low, see "gpios property" in
> > + Documentation/devicetree/bindings/gpio/gpio.txt. If the pin should be
> > + low to power down the board set it to "Active Low", otherwise set
> > + gpio to "Active High".
>
> Unfortunately, not all GPIO bindings support active high/low flags in
> the GPIO specifier. As such, the flags there are basically useless.
> Other bindings (e.g. IIRC the fixed-regulator binding) have added a
> separate active-high property to indicate the GPIO polarity. This
> binding should probably follow suite.
Humm, so are you saying of_get_named_gpio_flags() is deprecated?
There is a lot of code using this to get the flag
OF_GPIO_ACTIVE_LOW. Some of these users are very generic code:
drivers/leds/leds-gpio.c:
drivers/input/misc/rotary_encoder.c:
drivers/input/keyboard/gpio_keys.c:
drivers/input/keyboard/gpio_keys_polled.c:
drivers/hwmon/gpio-fan.c:
The only code using the "enable-active-high"
property is drivers/regulator/fixed.c although the binding
documentation twl6040.txt talks about it, but the code does not
implement it.
Could you point me towards some email discussion about this?
Thanks
Andrew
next prev parent reply other threads:[~2012-11-12 8:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 16:21 [PATCH 0/3] GPIO driver to turn power off Andrew Lunn
2012-11-11 16:21 ` [PATCH 1/3] gpio: Add simple poweroff-gpio driver Andrew Lunn
2012-11-11 22:03 ` Stephen Warren
2012-11-12 8:25 ` Andrew Lunn [this message]
2012-11-12 16:17 ` Stephen Warren
2012-11-12 18:19 ` Andrew Lunn
2012-11-12 18:43 ` Anton Vorontsov
2012-11-12 18:58 ` Stephen Warren
2012-11-12 19:17 ` Anton Vorontsov
2012-11-15 10:35 ` Linus Walleij
2012-11-15 10:59 ` Anton Vorontsov
2012-11-15 11:10 ` Linus Walleij
2012-11-21 13:17 ` Grant Likely
2012-11-15 18:00 ` Stephen Warren
2012-11-12 1:00 ` Linus Walleij
2012-11-12 1:12 ` Anton Vorontsov
2012-11-12 6:07 ` Andrew Lunn
2012-11-12 6:53 ` Anton Vorontsov
2012-11-15 18:05 ` Grant Likely
2012-11-15 18:11 ` Jamie Lentin
2012-11-15 18:21 ` Grant Likely
2012-11-21 13:20 ` Grant Likely
2012-11-11 16:21 ` [PATCH 2/3] ARM: Kirkwood: Convert DNSKW to use gpio-poweroff Andrew Lunn
2012-11-11 16:21 ` [PATCH 3/3] ARM: Kirkwood: Convert IB62x0 " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121112082546.GU22029@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox