From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] gpio: Add simple poweroff-gpio driver
Date: Thu, 15 Nov 2012 11:00:06 -0700 [thread overview]
Message-ID: <50A52DA6.3070409@wwwdotorg.org> (raw)
In-Reply-To: <20121115105954.GA17119@lizard>
On 11/15/2012 03:59 AM, Anton Vorontsov wrote:
> On Thu, Nov 15, 2012 at 11:35:36AM +0100, Linus Walleij wrote:
>> On Mon, Nov 12, 2012 at 7:58 PM, Stephen Warren <swarren@wwwdotorg•org> wrote:
>>> On 11/12/2012 11:43 AM, Anton Vorontsov wrote:
>>
>>>> Should the gpio driver fix its bindings then?.. Polarity is a quite
>>>> generic concept of a GPIO, and flags are there for a reason. I'd rather
>>>> prefer having
>>>
>>> There is no "GPIO driver" to fix; each GPIO driver has its own bindings,
>>> and unfortunately, some of the GPIO binding authors chose not to include
>>> any flags cell in the GPIO specifier (e.g. Samsung ARM SoCs IIRC, but
>>> there are probably more).
>>
>> So can I read this something like we have been too liberal with the
>> GPIO DT bindings and they are now a bit messy and need to be shaped
>> up? I don't know how to achieve that :-(
>
> I guess there's really no reason to panic. :)
>
> 'git grep gpio-cells Documentation/' shows just mrvl-gpio.txt and
> twl6040.txt having the wrong gpio-cells (i.e. 1).
If there are too-few cells, the binding and driver can always be
expanded to support more cells in a backwards-compatible way.
> But even these can use one cells for both flags and pin number (unless you
> really have 4294967295 GPIOs per controller).
>
> FWIW, current Samsung SOCs use 3 and even 4 cells for a GPIO specifier,
> which is absolutely fine. Plus, the Samsung bindings do specify the
> inversion flag. So, unless we have a lot of other [undocumented] bindings,
> I don't see a big mess. And everything I currently see is fixable.
Oh, I always thought that the Samsung bindings were one of the major
issues here, but you're right - they do have the inversion flag already.
So, perhaps there really isn't an issue, and we should revisit the
GPIO-based regulator bindings and drivers, and allow them to
(additionally) rely on the GPIO flags in the standard way.
next prev parent reply other threads:[~2012-11-15 18:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 16:21 [PATCH 0/3] GPIO driver to turn power off Andrew Lunn
2012-11-11 16:21 ` [PATCH 1/3] gpio: Add simple poweroff-gpio driver Andrew Lunn
2012-11-11 22:03 ` Stephen Warren
2012-11-12 8:25 ` Andrew Lunn
2012-11-12 16:17 ` Stephen Warren
2012-11-12 18:19 ` Andrew Lunn
2012-11-12 18:43 ` Anton Vorontsov
2012-11-12 18:58 ` Stephen Warren
2012-11-12 19:17 ` Anton Vorontsov
2012-11-15 10:35 ` Linus Walleij
2012-11-15 10:59 ` Anton Vorontsov
2012-11-15 11:10 ` Linus Walleij
2012-11-21 13:17 ` Grant Likely
2012-11-15 18:00 ` Stephen Warren [this message]
2012-11-12 1:00 ` Linus Walleij
2012-11-12 1:12 ` Anton Vorontsov
2012-11-12 6:07 ` Andrew Lunn
2012-11-12 6:53 ` Anton Vorontsov
2012-11-15 18:05 ` Grant Likely
2012-11-15 18:11 ` Jamie Lentin
2012-11-15 18:21 ` Grant Likely
2012-11-21 13:20 ` Grant Likely
2012-11-11 16:21 ` [PATCH 2/3] ARM: Kirkwood: Convert DNSKW to use gpio-poweroff Andrew Lunn
2012-11-11 16:21 ` [PATCH 3/3] ARM: Kirkwood: Convert IB62x0 " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A52DA6.3070409@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox