From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] ARM: OMAP: SRAM: resolve sparse warnings
Date: Tue, 1 Jan 2013 10:15:09 -0800 [thread overview]
Message-ID: <20130101181508.GB22106@atomide.com> (raw)
In-Reply-To: <20121224012500.13698.73653.stgit@dusk.lan>
* Paul Walmsley <paul@pwsan•com> [121223 17:30]:
> Commit bb77209432873214a796a70a4539e4ebdf3feb54 ("ARM: OMAP: Move
> omap2+ specific parts of sram.c to mach-omap2") adds some new sparse
> warnings:
>
> arch/arm/plat-omap/sram.c:43:6: warning: symbol 'omap_sram_push_address' was not declared. Should it be static?
> arch/arm/plat-omap/sram.c:65:6: warning: symbol 'omap_sram_reset' was not declared. Should it be static?
> arch/arm/plat-omap/sram.c:73:13: warning: symbol 'omap_map_sram' was not declared. Should it be static?
>
> Fix by creating a temporary header file containing prototypes for
> these SRAM functions - needed until the SRAM code is moved to
> drivers/. arch/arm/plat-omap/include/plat/sram.h can't be added due
> to ARM CONFIG_ARCH_MULTIPLATFORM restrictions on the use of the "plat/"
> include path shortcut.
Here too we should just include <plat/sram.h>, that's OK for the
multiplatform builds. Just drivers will not have it available.
Then eventually the issue disappears as this code becomes a regular
device driver.
Regards,
Tony
next prev parent reply other threads:[~2013-01-01 18:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-24 1:24 [PATCH 0/3] ARM: OMAP: resolve sparse warnings with v3.8-rc1 Paul Walmsley
2012-12-24 1:24 ` [PATCH 1/3] ARM: OMAP: 32k counter: resolve sparse warnings Paul Walmsley
2012-12-25 16:22 ` Santosh Shilimkar
2013-01-01 18:13 ` Tony Lindgren
2013-01-02 19:36 ` Paul Walmsley
2012-12-24 1:25 ` [PATCH 2/3] ARM: OMAP AM33xx: hwmod data: " Paul Walmsley
2012-12-26 4:10 ` Mugunthan V N
2012-12-24 1:25 ` [PATCH 3/3] ARM: OMAP: SRAM: " Paul Walmsley
2013-01-01 18:15 ` Tony Lindgren [this message]
2013-01-02 19:37 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130101181508.GB22106@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox