From: mugunthanvnm@ti•com (Mugunthan V N)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] ARM: OMAP AM33xx: hwmod data: resolve sparse warnings
Date: Wed, 26 Dec 2012 09:40:20 +0530 [thread overview]
Message-ID: <50DA78AC.9090601@ti.com> (raw)
In-Reply-To: <20121224012458.13698.43620.stgit@dusk.lan>
On 12/24/2012 6:55 AM, Paul Walmsley wrote:
> Commit 70384a6af0914d5dcec034643941e29d3e3e69f7 ("ARM: OMAP3+:
> hwmod: Add AM33XX HWMOD data for davinci_mdio module") adds two
> new sparse warnings:
>
> arch/arm/mach-omap2/omap_hwmod_33xx_data.c:2518:30: warning: symbol 'am33xx_mdio_addr_space' was not declared. Should it be static?
> arch/arm/mach-omap2/omap_hwmod_33xx_data.c:2526:26: warning: symbol 'am33xx_cpgmac0__mdio' was not declared. Should it be static?
>
> Fix by marking the two new records as static.
>
> Signed-off-by: Paul Walmsley <paul@pwsan•com>
> Cc: Mugunthan V N <mugunthanvnm@ti•com>
> Cc: Vaibhav Hiremath <hvaibhav@ti•com>
> Cc: Peter Korsgaard <jacmet@sunsite•dk>
> Cc: Richard Cochran <richardcochran@gmail•com>
> Cc: David S. Miller <davem@davemloft•net>
>
Looks good to me.
Acked-by : Mugunthan V N <mugunthanvnm@ti•com>
next prev parent reply other threads:[~2012-12-26 4:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-24 1:24 [PATCH 0/3] ARM: OMAP: resolve sparse warnings with v3.8-rc1 Paul Walmsley
2012-12-24 1:24 ` [PATCH 1/3] ARM: OMAP: 32k counter: resolve sparse warnings Paul Walmsley
2012-12-25 16:22 ` Santosh Shilimkar
2013-01-01 18:13 ` Tony Lindgren
2013-01-02 19:36 ` Paul Walmsley
2012-12-24 1:25 ` [PATCH 2/3] ARM: OMAP AM33xx: hwmod data: " Paul Walmsley
2012-12-26 4:10 ` Mugunthan V N [this message]
2012-12-24 1:25 ` [PATCH 3/3] ARM: OMAP: SRAM: " Paul Walmsley
2013-01-01 18:15 ` Tony Lindgren
2013-01-02 19:37 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DA78AC.9090601@ti.com \
--to=mugunthanvnm@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox