From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 29/38] thermal: exynos: Support both Exynos4x12 SoCs
Date: Mon, 17 Jun 2013 21:59:15 +0200 [thread overview]
Message-ID: <201306172159.15352.arnd@arndb.de> (raw)
In-Reply-To: <1371486863-12398-30-git-send-email-t.figa@samsung.com>
On Monday 17 June 2013, Tomasz Figa wrote:
> diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/exynos_thermal.c
> index 788b1dd..4cbe3ee 100644
> --- a/drivers/thermal/exynos_thermal.c
> +++ b/drivers/thermal/exynos_thermal.c
> @@ -817,7 +817,8 @@ static struct exynos_tmu_platform_data const exynos4210_default_tmu_data = {
> #define EXYNOS4210_TMU_DRV_DATA (NULL)
> #endif
>
> -#if defined(CONFIG_SOC_EXYNOS5250) || defined(CONFIG_SOC_EXYNOS4412)
> +#if defined(CONFIG_SOC_EXYNOS5250) || defined(CONFIG_SOC_EXYNOS4412) || \
> + defined(CONFIG_SOC_EXYNOS4212)
> static struct exynos_tmu_platform_data const exynos_default_tmu_data = {
> .threshold_falling = 10,
> .trigger_levels[0] = 85,
The patch is correct, but generally speaking I think we should get away from
having the drivers get configured per SoC on such a fine-grained level.
Better make this driver (and others) always work on all exynos variants.
Arnd
next prev parent reply other threads:[~2013-06-17 19:59 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 16:33 [PATCH v2 00/38] Thirty eight patches big Exynos cleanup Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 02/38] ARM: EXYNOS: Make ARCH_EXYNOS select USE_OF Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 03/38] ARM: SAMSUNG: Introduce SAMSUNG_ATAGS Kconfig entry Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 04/38] ARM: EXYNOS: common: Remove legacy PMU initialization code Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 05/38] ARM: EXYNOS: common: Remove legacy EINT " Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 06/38] ARM: EXYNOS: common: Remove legacy UART " Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 07/38] ARM: EXYNOS: Remove legacy dev- and setup- files Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 08/38] ARM: EXYNOS: common: Remove legacy interrupt initialization code Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 09/38] ARM: EXYNOS: common: Remove legacy timer " Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 10/38] ARM: EXYNOS: common: Remove platform device initialization Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 11/38] ARM: EXYNOS: common: Remove legacy mapping of chip ID block Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 12/38] ARM: EXYNOS: firmware: Remove check for device tree presence Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 13/38] ARM: EXYNOS: pm_domains: Remove legacy power domain registration code Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 14/38] ARM: SAMSUNG: Introduce GPIO_SAMSUNG Kconfig entry Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 15/38] ARM: EXYNOS: Provide compatibility stubs for PM code in pm-core.h header Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 16/38] ARM: SAMSUNG: Compile legacy IRQ and GPIO PM code only with ATAGS support Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 17/38] [media] platform: Check for ARCH_EXYNOS separately Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 18/38] USB: " Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 19/38] ARM: EXYNOS: Decouple ARCH_EXYNOS from PLAT_S5P Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 20/38] ARM: SAMSUNG: pm: Include most of mach/ headers conditionally Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 21/38] ARM: EXYNOS: Do not select legacy Kconfig symbols any more Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 22/38] ARM: EXYNOS: Remove setup-i2c0.c Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 23/38] ARM: EXYNOS: Remove mach/gpio.h Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 24/38] ARM: EXYNOS: Remove mach/regs-gpio.h header Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 25/38] ARM: SAMSUNG: Make legacy MFC support code depend on SAMSUNG_ATAGS Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 26/38] ARM: EXYNOS: Select SPARSE_IRQ for Exynos Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 27/38] ARM: EXYNOS: Remove mach/irqs.h header Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 28/38] ARM: EXYNOS: Remove unused base addresses from mach/map.h header Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 29/38] thermal: exynos: Support both Exynos4x12 SoCs Tomasz Figa
2013-06-17 19:59 ` Arnd Bergmann [this message]
2013-06-17 23:34 ` Eduardo Valentin
2013-06-18 8:54 ` amit daniel kachhap
2013-06-18 13:02 ` Arnd Bergmann
2013-06-17 16:34 ` [PATCH v2 30/38] ARM: EXYNOS: Remove CONFIG_SOC_EXYNOS4412 Tomasz Figa
2013-06-18 9:17 ` Kukjin Kim
2013-06-18 9:31 ` Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 31/38] cpufreq: exynos4x12: Remove check for SOC_EXYNOS4412 Tomasz Figa
2013-06-18 3:18 ` Viresh Kumar
2013-06-18 9:18 ` Kukjin Kim
2013-06-17 16:34 ` [PATCH v2 32/38] [media] exynos4-is: " Tomasz Figa
2013-06-18 9:18 ` Kukjin Kim
2013-06-17 16:34 ` [PATCH v2 33/38] thermal: exynos: " Tomasz Figa
2013-06-18 9:19 ` Kukjin Kim
2013-06-17 16:34 ` [PATCH v2 34/38] ARM: EXYNOS: Remove mach/regs-usb-phy.h header Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 35/38] ARM: EXYNOS: Remove custom init_irq callbacks Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 36/38] ARM: EXYNOS: Use exynos_init_io() as map_io callback Tomasz Figa
2013-06-18 9:36 ` Kukjin Kim
2013-06-18 9:48 ` Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 37/38] ARM: EXYNOS: Remove legacy L2X0 initialization Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 38/38] ARM: EXYNOS: Remove remaining dead code after non-DT support removal Tomasz Figa
2013-06-17 20:00 ` [PATCH v2 00/38] Thirty eight patches big Exynos cleanup Arnd Bergmann
2013-06-18 10:23 ` Kukjin Kim
2013-06-18 11:11 ` Tomasz Figa
2013-06-18 17:51 ` Kukjin Kim
2013-06-18 18:09 ` Tomasz Figa
2013-06-18 18:29 ` Arnd Bergmann
2013-06-18 20:15 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306172159.15352.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox