From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 00/38] Thirty eight patches big Exynos cleanup
Date: Wed, 19 Jun 2013 02:51:56 +0900 [thread overview]
Message-ID: <51C09E3C.5050108@samsung.com> (raw)
In-Reply-To: <1490899.cyTqiG9bBR@amdc1227>
On 06/18/13 20:11, Tomasz Figa wrote:
> On Tuesday 18 of June 2013 19:23:29 Kukjin Kim wrote:
>> Tomasz Figa wrote:
>>> Hi All,
>>>
>>> As I promised, I am doing some spring (or rather summer) cleaning
>>> of Exynos- and Samsung- related code.
>>>
>>> This first part consists mostly of removing dead code remaining after
>>> removal of ATAGS support for Exynos, but several patches cleans up
>>> other things found by the way.
>>>
>>> See particular patches for more detailed description.
>>>
>>> On Exynos4210-based Trats board:
>>> Tested-by: Tomasz Figa<t.figa@samsung•com>
>>>
>>> Build tested every patch with s3c6400_defconfig, s5pv210_defconfig
>>> and exynos_defconfig.
>>>
>>> Changes since v1:
>>> - Split patches removing SOC_EXYNOS4412
>>> - Adjusted drivers to check for ARCH_EXYNOS in addition to PLAT_S5P
>>> - Fixed compilation issue on s5pc100
>>> - Removed empty line from mach-exynos/Makefile
>>> - Removed SAMSUNG_GPIOLIB_4BIT selection from ARCH_EXYNOS
>>> - Sorted Kconfig and Makefile entries
>>> - Added additional cleanup from Arnd (split and slightly modified)
>>
>> Tomasz, good job.
>
> Thanks.
>
>> After looking at, almost same with your previous version but modifying 16,
>> 19, 21, 25(just Cc) and adding some patches 17, 18, 29 and 35 to 38. Would
>> be helpful to me if you could note about that in this series ;-)
>
> OK, my bad, haven't though about it, sorry. Will remember to do it next time
> such series update happens.
>
> By the way, patch 14 has been updated as well.
>
Thanks ;)
> Best regards,
> Tomasz
>
>> Anyway, looks good I will apply this series
>
> OK, thanks.
>
>> except removing
>> CONFIG_SOC_EXYNOS4412 patches.
>
> I don't really understand this decision, but if you really insist...
>
Sorry about that, but exynos4412 is not same with exynos4212 except
number of cores and exynos4412 is not one kind...
> Still, I think current setup is wrong, because you need to specify both SoCs
> in drivers and both Kconfig entries must have "select" and "depends on" clauses
> duplicated, while there are places currently where only one has been specified
> by mistake.
>
> So if we can't get this duplication removed, I'd suggest introducing
> CONFIG_SOC_EXYNOS4X12 which would represent the whole SoC series and making
> existing two entries just simple bools selecting the new one.
>
Could be a solution but let's wait until something will be implemented
in mainline for exynos4412 not exynos4212 :)
Thanks,
- Kukjin
next prev parent reply other threads:[~2013-06-18 17:51 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 16:33 [PATCH v2 00/38] Thirty eight patches big Exynos cleanup Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 02/38] ARM: EXYNOS: Make ARCH_EXYNOS select USE_OF Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 03/38] ARM: SAMSUNG: Introduce SAMSUNG_ATAGS Kconfig entry Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 04/38] ARM: EXYNOS: common: Remove legacy PMU initialization code Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 05/38] ARM: EXYNOS: common: Remove legacy EINT " Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 06/38] ARM: EXYNOS: common: Remove legacy UART " Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 07/38] ARM: EXYNOS: Remove legacy dev- and setup- files Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 08/38] ARM: EXYNOS: common: Remove legacy interrupt initialization code Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 09/38] ARM: EXYNOS: common: Remove legacy timer " Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 10/38] ARM: EXYNOS: common: Remove platform device initialization Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 11/38] ARM: EXYNOS: common: Remove legacy mapping of chip ID block Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 12/38] ARM: EXYNOS: firmware: Remove check for device tree presence Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 13/38] ARM: EXYNOS: pm_domains: Remove legacy power domain registration code Tomasz Figa
2013-06-17 16:33 ` [PATCH v2 14/38] ARM: SAMSUNG: Introduce GPIO_SAMSUNG Kconfig entry Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 15/38] ARM: EXYNOS: Provide compatibility stubs for PM code in pm-core.h header Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 16/38] ARM: SAMSUNG: Compile legacy IRQ and GPIO PM code only with ATAGS support Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 17/38] [media] platform: Check for ARCH_EXYNOS separately Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 18/38] USB: " Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 19/38] ARM: EXYNOS: Decouple ARCH_EXYNOS from PLAT_S5P Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 20/38] ARM: SAMSUNG: pm: Include most of mach/ headers conditionally Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 21/38] ARM: EXYNOS: Do not select legacy Kconfig symbols any more Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 22/38] ARM: EXYNOS: Remove setup-i2c0.c Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 23/38] ARM: EXYNOS: Remove mach/gpio.h Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 24/38] ARM: EXYNOS: Remove mach/regs-gpio.h header Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 25/38] ARM: SAMSUNG: Make legacy MFC support code depend on SAMSUNG_ATAGS Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 26/38] ARM: EXYNOS: Select SPARSE_IRQ for Exynos Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 27/38] ARM: EXYNOS: Remove mach/irqs.h header Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 28/38] ARM: EXYNOS: Remove unused base addresses from mach/map.h header Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 29/38] thermal: exynos: Support both Exynos4x12 SoCs Tomasz Figa
2013-06-17 19:59 ` Arnd Bergmann
2013-06-17 23:34 ` Eduardo Valentin
2013-06-18 8:54 ` amit daniel kachhap
2013-06-18 13:02 ` Arnd Bergmann
2013-06-17 16:34 ` [PATCH v2 30/38] ARM: EXYNOS: Remove CONFIG_SOC_EXYNOS4412 Tomasz Figa
2013-06-18 9:17 ` Kukjin Kim
2013-06-18 9:31 ` Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 31/38] cpufreq: exynos4x12: Remove check for SOC_EXYNOS4412 Tomasz Figa
2013-06-18 3:18 ` Viresh Kumar
2013-06-18 9:18 ` Kukjin Kim
2013-06-17 16:34 ` [PATCH v2 32/38] [media] exynos4-is: " Tomasz Figa
2013-06-18 9:18 ` Kukjin Kim
2013-06-17 16:34 ` [PATCH v2 33/38] thermal: exynos: " Tomasz Figa
2013-06-18 9:19 ` Kukjin Kim
2013-06-17 16:34 ` [PATCH v2 34/38] ARM: EXYNOS: Remove mach/regs-usb-phy.h header Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 35/38] ARM: EXYNOS: Remove custom init_irq callbacks Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 36/38] ARM: EXYNOS: Use exynos_init_io() as map_io callback Tomasz Figa
2013-06-18 9:36 ` Kukjin Kim
2013-06-18 9:48 ` Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 37/38] ARM: EXYNOS: Remove legacy L2X0 initialization Tomasz Figa
2013-06-17 16:34 ` [PATCH v2 38/38] ARM: EXYNOS: Remove remaining dead code after non-DT support removal Tomasz Figa
2013-06-17 20:00 ` [PATCH v2 00/38] Thirty eight patches big Exynos cleanup Arnd Bergmann
2013-06-18 10:23 ` Kukjin Kim
2013-06-18 11:11 ` Tomasz Figa
2013-06-18 17:51 ` Kukjin Kim [this message]
2013-06-18 18:09 ` Tomasz Figa
2013-06-18 18:29 ` Arnd Bergmann
2013-06-18 20:15 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C09E3C.5050108@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox