public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: peter.chen@freescale•com (Peter Chen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 12/15] usb: phy: Add set_wakeup API
Date: Mon, 9 Dec 2013 17:12:57 +0800	[thread overview]
Message-ID: <20131209091256.GC5291@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <52A58252.6090502@pengutronix.de>

On Mon, Dec 09, 2013 at 09:41:54AM +0100, Marc Kleine-Budde wrote:
> On 12/09/2013 07:31 AM, Peter Chen wrote:
> > This API is used to set wakeup enable at PHY registers, in that
> > case, the PHY can be waken up from suspend due to external events,
> 
> I' no native speaker, but I think it's "to be woken up".

Thanks, will change.

> >  
> >  static inline int
> > +usb_phy_set_wakeup(struct usb_phy *x, bool enabled)
> > +{
> > +	if (x && x->set_wakeup)
> 
> can x be NULL?
> 

Possible, this function is PHY's API, it may be called uninitialized.

Peter

> > +		return x->set_wakeup(x, enabled);
> > +	else
> > +		return 0;
> > +}
> > +
> > +static inline int
> >  usb_phy_notify_connect(struct usb_phy *x, enum usb_device_speed speed)
> >  {
> >  	if (x && x->notify_connect)
> > 
> 
> Marc
> 
> -- 
> Pengutronix e.K.                  | Marc Kleine-Budde           |
> Industrial Linux Solutions        | Phone: +49-231-2826-924     |
> Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |
> 



-- 

Best Regards,
Peter Chen

  reply	other threads:[~2013-12-09  9:12 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  6:30 [PATCH v5 00/15] Add power management support for mxs phy Peter Chen
2013-12-09  6:30 ` [PATCH v5 01/15] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2013-12-09  6:30 ` [PATCH v5 02/15] usb: phy-mxs: Add platform judgement code Peter Chen
2013-12-09  6:30 ` [PATCH v5 03/15] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-12-09  6:30 ` [PATCH v5 04/15] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-12-09  6:30 ` [PATCH v5 05/15] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-12-09  6:30 ` [PATCH v5 06/15] usb: phy-mxs: Add anatop regmap Peter Chen
2013-12-09  6:30 ` [PATCH v5 07/15] usb: phy: add notify suspend and resume callback Peter Chen
2013-12-09  6:30 ` [PATCH v5 08/15] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-12-09  8:31   ` Marc Kleine-Budde
2013-12-09  9:00     ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 09/15] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
2013-12-09  8:38   ` Marc Kleine-Budde
2013-12-09  9:07     ` Peter Chen
2013-12-09  9:52       ` Marc Kleine-Budde
2013-12-10  1:45         ` Peter Chen
2013-12-09  6:30 ` [PATCH v5 10/15] ARM: dts: imx: add mxs phy controller id Peter Chen
2013-12-09  6:31 ` [PATCH v5 11/15] usb: phy-mxs: add " Peter Chen
2013-12-09  6:31 ` [PATCH v5 12/15] usb: phy: Add set_wakeup API Peter Chen
2013-12-09  8:41   ` Marc Kleine-Budde
2013-12-09  9:12     ` Peter Chen [this message]
2013-12-09  6:31 ` [PATCH v5 13/15] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-12-09  6:31 ` [PATCH v5 14/15] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-12-09  6:31 ` [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd Peter Chen
2013-12-09  9:05   ` Marc Kleine-Budde
2013-12-09  9:19     ` Peter Chen
2013-12-09 10:00       ` Marc Kleine-Budde
2013-12-09 18:20   ` Sergei Shtylyov
2013-12-10  1:47     ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131209091256.GC5291@shlinux1.ap.freescale.net \
    --to=peter.chen@freescale$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox