From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd
Date: Mon, 09 Dec 2013 21:20:08 +0300 [thread overview]
Message-ID: <52A609D8.1050300@cogentembedded.com> (raw)
In-Reply-To: <1386570664-6713-16-git-send-email-peter.chen@freescale.com>
Hello.
On 12/09/2013 09:31 AM, Peter Chen wrote:
> After clear portsc.phcd, PHY needs 200us stable time for switch
> 32K clock to AHB clock.
> Signed-off-by: Peter Chen <peter.chen@freescale•com>
> ---
> drivers/usb/phy/phy-mxs-usb.c | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> index e18fdf3..7ae5225 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/drivers/usb/phy/phy-mxs-usb.c
> @@ -151,6 +151,15 @@ static inline bool is_imx6sl_phy(struct mxs_phy *mxs_phy)
> return mxs_phy->data == &imx6sl_phy_data;
> }
>
> +/*
> + * PHY needs some 32K cycles to switch from 32K clock to
> + * bus (such as AHB/AXI, etc) clock.
> + */
> +static void mxs_phy_clock_switch(void)
> +{
> + usleep_range(300, 400);
> +}
> +
Don't think this is a good name for this function since it doesn't really
switch anything, just waits. I'd suggest something like
mxs_phy_clock_switch_delay().
WBR, Sergei
next prev parent reply other threads:[~2013-12-09 18:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 6:30 [PATCH v5 00/15] Add power management support for mxs phy Peter Chen
2013-12-09 6:30 ` [PATCH v5 01/15] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2013-12-09 6:30 ` [PATCH v5 02/15] usb: phy-mxs: Add platform judgement code Peter Chen
2013-12-09 6:30 ` [PATCH v5 03/15] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-12-09 6:30 ` [PATCH v5 04/15] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-12-09 6:30 ` [PATCH v5 05/15] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-12-09 6:30 ` [PATCH v5 06/15] usb: phy-mxs: Add anatop regmap Peter Chen
2013-12-09 6:30 ` [PATCH v5 07/15] usb: phy: add notify suspend and resume callback Peter Chen
2013-12-09 6:30 ` [PATCH v5 08/15] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-12-09 8:31 ` Marc Kleine-Budde
2013-12-09 9:00 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 09/15] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
2013-12-09 8:38 ` Marc Kleine-Budde
2013-12-09 9:07 ` Peter Chen
2013-12-09 9:52 ` Marc Kleine-Budde
2013-12-10 1:45 ` Peter Chen
2013-12-09 6:30 ` [PATCH v5 10/15] ARM: dts: imx: add mxs phy controller id Peter Chen
2013-12-09 6:31 ` [PATCH v5 11/15] usb: phy-mxs: add " Peter Chen
2013-12-09 6:31 ` [PATCH v5 12/15] usb: phy: Add set_wakeup API Peter Chen
2013-12-09 8:41 ` Marc Kleine-Budde
2013-12-09 9:12 ` Peter Chen
2013-12-09 6:31 ` [PATCH v5 13/15] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-12-09 6:31 ` [PATCH v5 14/15] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-12-09 6:31 ` [PATCH v5 15/15] usb: phy-mxs: Add sync time after controller clear phcd Peter Chen
2013-12-09 9:05 ` Marc Kleine-Budde
2013-12-09 9:19 ` Peter Chen
2013-12-09 10:00 ` Marc Kleine-Budde
2013-12-09 18:20 ` Sergei Shtylyov [this message]
2013-12-10 1:47 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A609D8.1050300@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox