From: carlo@caione•org (Carlo Caione)
To: linux-arm-kernel@lists•infradead.org
Subject: [linux-sunxi] Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem
Date: Tue, 11 Mar 2014 22:06:59 +0100 [thread overview]
Message-ID: <20140311210659.GA10961@localhost.fastwebnet.it> (raw)
In-Reply-To: <20140311192940.GA28112@sirena.org.uk>
On Tue, Mar 11, 2014 at 07:29:40PM +0000, Mark Brown wrote:
> On Tue, Mar 11, 2014 at 08:24:11PM +0100, Carlo Caione wrote:
> > On Mon, Mar 03, 2014 at 10:56:16AM +0900, Mark Brown wrote:
>
> > > > + regulators = of_find_node_by_name(np, "regulators");
> > > > + if (!regulators) {
> > > > + dev_err(&pdev->dev, "regulators node not found\n");
> > > > + return -EINVAL;
> > > > + }
>
> > > The driver should be able to start up with no configuration provided at
> > > all except for the device being registered - the user won't be able to
> > > change anything but they will be able to read the current state of the
> > > hardware which can be useful for diagnostics.
>
> > If the device is DT enabled and no configuration is provided for
> > regulators, these are disabled according to:
>
> > http://lxr.linux.no/linux+v3.13.5/drivers/regulator/core.c#L3797
>
> > Am I missing something or do you have any pointer?
>
> With the above code the driver will return an error and never get as far
> as registering the regulator.
I agree, but if I register the regulators without having the constrains
defined in the DT, when regulator_init_complete() is
called, the regulators are disabled powering off the SoC (at least for
DCDC2 and DCDC3).
Thanks,
--
Carlo Caione
next prev parent reply other threads:[~2014-03-11 21:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 16:45 [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209 Carlo Caione
2014-03-01 16:45 ` [PATCH 1/7] mfd: AXP20x: Add mfd driver for AXP20x PMIC Carlo Caione
2014-03-07 18:09 ` Maxime Ripard
2014-03-08 11:31 ` Carlo Caione
2014-03-09 9:11 ` Maxime Ripard
2014-03-01 16:45 ` [PATCH 2/7] mfd: AXP20x: Add bindings documentation Carlo Caione
2014-03-07 18:13 ` Maxime Ripard
2014-03-08 11:38 ` [linux-sunxi] " Carlo Caione
2014-03-01 16:45 ` [PATCH 3/7] ARM: dts: cubieboard2: Add AXP209 support Carlo Caione
2014-03-07 18:13 ` Maxime Ripard
2014-03-01 16:45 ` [PATCH 4/7] input: misc: Add driver for AXP20x Power Enable Key Carlo Caione
2014-03-07 18:18 ` Maxime Ripard
2014-03-01 16:45 ` [PATCH 5/7] input: misc: Add ABI docs for AXP20x PEK Carlo Caione
2014-03-01 16:45 ` [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem Carlo Caione
2014-03-03 1:56 ` Mark Brown
2014-03-04 20:56 ` [linux-sunxi] " Carlo Caione
2014-03-11 19:24 ` Carlo Caione
2014-03-11 19:29 ` Mark Brown
2014-03-11 21:06 ` Carlo Caione [this message]
2014-03-12 0:38 ` Mark Brown
2014-03-07 18:22 ` Maxime Ripard
2014-03-08 11:43 ` [linux-sunxi] " Carlo Caione
2014-03-09 7:51 ` Mark Brown
2014-03-09 8:56 ` Carlo Caione
2014-03-01 16:45 ` [PATCH 7/7] ARM: dts: Cubieboard2: Add support for AXP209 regulators Carlo Caione
2014-03-01 16:56 ` [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209 Hans de Goede
2014-03-01 17:17 ` Carlo Caione
2014-03-01 19:29 ` [linux-sunxi] " Hans de Goede
2014-03-05 20:02 ` Hans de Goede
2014-03-05 20:46 ` Carlo Caione
2014-03-06 10:07 ` Hans de Goede
2014-03-06 10:10 ` Carlo Caione
2014-03-06 11:05 ` Hans de Goede
2014-03-06 11:32 ` Carlo Caione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311210659.GA10961@localhost.fastwebnet.it \
--to=carlo@caione$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox