From: hdegoede@redhat•com (Hans de Goede)
To: linux-arm-kernel@lists•infradead.org
Subject: [linux-sunxi] Re: [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209
Date: Wed, 05 Mar 2014 21:02:39 +0100 [thread overview]
Message-ID: <531782DF.6090209@redhat.com> (raw)
In-Reply-To: <53123507.6020607@redhat.com>
Hi,
On 03/01/2014 08:29 PM, Hans de Goede wrote:
> Hi,
>
> On 03/01/2014 06:17 PM, Carlo Caione wrote:
>> On Sat, Mar 1, 2014 at 5:56 PM, Hans de Goede <hdegoede@redhat•com> wrote:
>>> Hi Carlo,
>>>
>>> Great work, thanks for all the time you're putting into this!
>>
>> Hi Hans :)
>>
>>> I've 2 questions:
>>>
>>> 1) What dependencies does this patch-set have? Obviously it needs the NMI irq
>>> patches for A20, anything else ? I no longer see any use of a special flag
>>> for ack on unmask, is that no longer needed ?
>>
>> Yes, the only dependency is on the NMI controller patch.
>> After a discussion with Maxime and Thomas I decided to not push for
>> including the special flag for ack on unmask in the irqchip core but
>> to use the unmask callback as in the v3 version of the NMI controller
>> driver (so no flag needed)
>>
>>> 2) No poweroff functionality ? That would be really great to have.
>>
>> Actually in [PATCH 1/7] I support the poweroff using the pm_power_off hook.
>
> Ah I missed that, cool.
>
> I'm doing with sunxi hacking for today, but I'll add these to sunxi-devel
> and them give them a test run tomorrow.
So I've added your patches to my sunxi-devel tree and they work as advertised :)
I've also added dt support for the axp209 to the cubietruck dts file, to avoid
things becoming a copy and paste fest I've introduced a new axp209.dtsi file,
as well as did some fixes to the existing sun?i-a*.dtsi files, see my tree here:
https://github.com/jwrdegoede/linux-sunxi/commits/sunxi-devel
If you agree this is a good idea feel free to steal it all for the next
revision of your patch-set :)
Note that I've still left some copy-paste parts inside the per board dts files,
specifically things which may differ per board, ie we know already that A10
boards will have a different interrupt parent for the interrupt.
Thanks for your work on this!
Regards,
Hans
next prev parent reply other threads:[~2014-03-05 20:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 16:45 [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209 Carlo Caione
2014-03-01 16:45 ` [PATCH 1/7] mfd: AXP20x: Add mfd driver for AXP20x PMIC Carlo Caione
2014-03-07 18:09 ` Maxime Ripard
2014-03-08 11:31 ` Carlo Caione
2014-03-09 9:11 ` Maxime Ripard
2014-03-01 16:45 ` [PATCH 2/7] mfd: AXP20x: Add bindings documentation Carlo Caione
2014-03-07 18:13 ` Maxime Ripard
2014-03-08 11:38 ` [linux-sunxi] " Carlo Caione
2014-03-01 16:45 ` [PATCH 3/7] ARM: dts: cubieboard2: Add AXP209 support Carlo Caione
2014-03-07 18:13 ` Maxime Ripard
2014-03-01 16:45 ` [PATCH 4/7] input: misc: Add driver for AXP20x Power Enable Key Carlo Caione
2014-03-07 18:18 ` Maxime Ripard
2014-03-01 16:45 ` [PATCH 5/7] input: misc: Add ABI docs for AXP20x PEK Carlo Caione
2014-03-01 16:45 ` [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem Carlo Caione
2014-03-03 1:56 ` Mark Brown
2014-03-04 20:56 ` [linux-sunxi] " Carlo Caione
2014-03-11 19:24 ` Carlo Caione
2014-03-11 19:29 ` Mark Brown
2014-03-11 21:06 ` Carlo Caione
2014-03-12 0:38 ` Mark Brown
2014-03-07 18:22 ` Maxime Ripard
2014-03-08 11:43 ` [linux-sunxi] " Carlo Caione
2014-03-09 7:51 ` Mark Brown
2014-03-09 8:56 ` Carlo Caione
2014-03-01 16:45 ` [PATCH 7/7] ARM: dts: Cubieboard2: Add support for AXP209 regulators Carlo Caione
2014-03-01 16:56 ` [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209 Hans de Goede
2014-03-01 17:17 ` Carlo Caione
2014-03-01 19:29 ` [linux-sunxi] " Hans de Goede
2014-03-05 20:02 ` Hans de Goede [this message]
2014-03-05 20:46 ` Carlo Caione
2014-03-06 10:07 ` Hans de Goede
2014-03-06 10:10 ` Carlo Caione
2014-03-06 11:05 ` Hans de Goede
2014-03-06 11:32 ` Carlo Caione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531782DF.6090209@redhat.com \
--to=hdegoede@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox