From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/3] arm64: spin-table: handle unmapped cpu-release-addrs
Date: Fri, 15 Aug 2014 13:53:24 +0100 [thread overview]
Message-ID: <20140815125324.GQ27466@arm.com> (raw)
In-Reply-To: <CAKv+Gu-2RyWY4V7zoOQEi3As96kmmAMae2s3YauJ4bL9-h+sdg@mail.gmail.com>
On Fri, Aug 15, 2014 at 01:07:16PM +0100, Ard Biesheuvel wrote:
> On 15 August 2014 13:57, Will Deacon <will.deacon@arm•com> wrote:
> > On Thu, Aug 14, 2014 at 07:10:13PM +0100, Ard Biesheuvel wrote:
> >> Patch 3/3 makes the EFI stub load Image at the lowest 2 meg boundary +
> >> TEXT_OFFSET instead of erroring out when base of DRAM + TEXT_OFFSET is
> >> occupied. This is necessary as the randomized TEXT_OFFSET could
> >> potentially conflict with reserved areas at the base of DRAM if a low
> >> value happens to be chosen.
> >>
> >> Patch 1/3 fixes the resulting breakage on APM Mustang in bringing up
> >> the secondaries, as on that board in particular, the reserved area at
> >> the base of DRAM contains the holding pen, and loading Image higher up
> >> makes the mailbox inaccessible through the linear mapping hence the
> >> need for ioremap_cache()
> >>
> >> Patch 2/3 is also a fix for a potential issue on UEFI boot, but it is
> >> unrelated to 1/3 and 3/3
> >
> > I was planning to take all of these for 3.18 as there's no regression here
> > (the fuzzing is a new debug feature and defaults to `n'). Do you think these
> > qualify as -rc1 material?
> >
>
> Considering that TEXT_OFFSET fuzzing is recommended to be turned on
> for distro kernels, I would say this is definitely appropriate for
> 3.17
Whilst I see that in the commit log, the same recommendation doesn't appear
in the Kconfig text and I'm not sure that it's such a wise thing to say
either. From a distribution's point of view, I think I'd want any kernel
issues to be as reproducible as possible, and fuzzing the text offset seems
to go against that.
Will
next prev parent reply other threads:[~2014-08-15 12:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKv+Gu_UjRNhhiM0GPsKRdXRtmEnY6cbpY-JZ33RUMapbPYsbQ@mail.gmail.com>
2014-08-13 12:58 ` [PATCH v2 1/3] arm64: spin-table: handle unmapped cpu-release-addrs Mark Rutland
2014-08-14 17:13 ` Catalin Marinas
2014-08-14 18:10 ` Ard Biesheuvel
2014-08-15 11:57 ` Will Deacon
2014-08-15 12:07 ` Ard Biesheuvel
2014-08-15 12:53 ` Will Deacon [this message]
2014-08-15 13:28 ` Ard Biesheuvel
2014-08-15 14:35 ` Mark Salter
2014-08-15 14:38 ` Will Deacon
2014-08-17 0:06 ` Leif Lindholm
2014-08-18 16:47 ` Catalin Marinas
2014-08-18 17:22 ` Ard Biesheuvel
2014-07-30 10:59 [PATCH 0/3 v2] arm64/efi: improve TEXT_OFFSET handling Ard Biesheuvel
2014-07-30 10:59 ` [PATCH v2 1/3] arm64: spin-table: handle unmapped cpu-release-addrs Ard Biesheuvel
2014-07-30 11:30 ` Will Deacon
2014-07-30 12:00 ` Ard Biesheuvel
2014-07-30 12:05 ` Ard Biesheuvel
2014-07-30 12:30 ` Mark Rutland
2014-07-30 12:42 ` Will Deacon
2014-07-30 12:49 ` Mark Rutland
2014-07-30 13:10 ` Ard Biesheuvel
2014-07-30 13:28 ` Ard Biesheuvel
2014-07-30 19:17 ` Ard Biesheuvel
2014-07-31 9:45 ` Will Deacon
2014-07-31 9:58 ` Mark Rutland
2014-07-31 10:04 ` Will Deacon
2014-07-31 10:16 ` Ard Biesheuvel
2014-07-31 10:39 ` Mark Rutland
2014-08-01 11:35 ` Ard Biesheuvel
2014-07-31 14:41 ` Mark Salter
2014-07-31 10:01 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815125324.GQ27466@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox