From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/6] arm64: Add support for hooks to handle undefined instructions
Date: Tue, 26 Aug 2014 19:14:06 +0100 [thread overview]
Message-ID: <20140826181405.GG23445@arm.com> (raw)
In-Reply-To: <9hhy4ube1tz.fsf@arm.com>
On Tue, Aug 26, 2014 at 03:56:56PM +0100, Punit Agrawal wrote:
> Will Deacon <will.deacon@arm•com> writes:
> > On Tue, Aug 26, 2014 at 11:28:47AM +0100, Punit Agrawal wrote:
> >> asmlinkage void __exception do_undefinstr(struct pt_regs *regs)
> >> {
> >> siginfo_t info;
> >> @@ -266,6 +329,9 @@ asmlinkage void __exception do_undefinstr(struct pt_regs *regs)
> >> if (!aarch32_break_handler(regs))
> >> return;
> >>
> >> + if (call_undef_hook(regs) == 0)
> >> + return;
> >
> > I'd like to reuse this hook for the aarch32 break hooks (you can see the
> > direct call in the context above). That means adding support for thumb
> > after all. Is there a reason you've been avoiding that?
>
> None, other than to not add code before it's needed. I've just had a
> quick look at break handler and it looks pretty straight forward to fold
> that change in this set. Are you OK with that?
Just do it as a separate patch on top of this one.
Will
next prev parent reply other threads:[~2014-08-26 18:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 10:28 [PATCH 0/6] Legacy instruction emulation for arm64 Punit Agrawal
2014-08-26 10:28 ` [PATCH 1/6] arm: Fix in-correct barrier usage in SWP{B} emulation Punit Agrawal
2014-08-26 13:04 ` Will Deacon
2014-08-27 16:40 ` Catalin Marinas
2014-08-27 17:05 ` Punit Agrawal
2014-08-26 10:28 ` [PATCH 2/6] arm64: Create arch debugfs directory Punit Agrawal
2014-08-26 10:28 ` [PATCH 3/6] arm64: Add support for hooks to handle undefined instructions Punit Agrawal
2014-08-26 13:13 ` Will Deacon
2014-08-26 14:21 ` Ard Biesheuvel
2014-08-26 14:30 ` Will Deacon
2014-08-27 16:47 ` Catalin Marinas
2014-08-27 16:51 ` Will Deacon
2014-08-26 14:56 ` Punit Agrawal
2014-08-26 18:14 ` Will Deacon [this message]
2014-08-27 16:58 ` Catalin Marinas
2014-08-26 10:28 ` [PATCH 4/6] arm64: Add AArch32 instruction set condition code checks Punit Agrawal
2014-08-26 10:28 ` [PATCH 5/6] arm64: Port SWP/SWPB emulation support from arm Punit Agrawal
2014-08-26 11:32 ` Arnd Bergmann
2014-08-26 12:25 ` Will Deacon
2014-08-26 13:26 ` Arnd Bergmann
2014-08-26 13:56 ` Will Deacon
2014-08-27 17:35 ` Punit Agrawal
2014-08-27 18:30 ` Arnd Bergmann
2014-08-28 10:21 ` Punit Agrawal
2014-08-27 17:29 ` Catalin Marinas
2014-08-26 10:28 ` [PATCH 6/6] arm64: Emulate CP15 Barrier instructions Punit Agrawal
2014-08-26 13:16 ` Will Deacon
2014-08-27 17:40 ` Catalin Marinas
2014-08-28 9:34 ` Punit Agrawal
2014-08-28 9:42 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826181405.GG23445@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox