From: mika.westerberg@linux•intel.com (Mika Westerberg)
To: linux-arm-kernel@lists•infradead.org
Subject: next build: 304 warnings 0 failures (next/next-20141013)
Date: Tue, 14 Oct 2014 16:16:43 +0300 [thread overview]
Message-ID: <20141014131643.GG2255@lahna.fi.intel.com> (raw)
In-Reply-To: <7136705.nXM3eChrM0@wuerfel>
On Tue, Oct 14, 2014 at 11:17:33AM +0200, Arnd Bergmann wrote:
> On Tuesday 14 October 2014 11:54:32 Mika Westerberg wrote:
> >
> > Fenghua's build bot noticed this some time ago and it got fixed but
> > looks like we forgot to merge the fix to the _DSD patch series.
> >
> > Here it is again. Rafael, do you want to take this on top of the
> > 'device-properties' -branch?
> >
> > From: Mika Westerberg <mika.westerberg@linux•intel.com>
> > Subject: [PATCH] leds: Move gpiod to be last member of struct gpio_led
> >
> > Commit 8b0d4dc3d44 (leds: leds-gpio: Add support for GPIO descriptors)
> > added a new member 'gpiod' to struct gpio_led to support GPIO descriptors.
> > This is fine as long as board files use designated initializers but some
> > fail to do so causing following build errors:
> >
> > arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default]
> > arch/arm/mach-omap1/board-htcherald.c:296:2: warning: (near initialization for 'gpio_leds[0].gpiod') [enabled by default]
> > arch/arm/mach-omap1/board-htcherald.c:297:2: warning: initialization makes pointer from integer without a cast [enabled by default]
> > arch/arm/mach-omap1/board-htcherald.c:297:2: warning: (near initialization for 'gpio_leds[1].gpiod') [enabled by default]
> >
> > To be on the safe side move the 'gpiod' member to be the last member of struct
> > gpiod_led.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux•intel.com>
> >
>
> Acked-by: Arnd Bergmann <arnd@arndb•de>
>
> Looks good to me. Should we also do the other patch to be on the safe side?
I think it is good idea.
> 8<-------
> Subject: [PATCH] ARM: OMAP1: htcherald: use named initializers for gpio-leds
>
> A recent change to the gpio-leds driver broke the platform data definition
> in the htcherald file:
>
> arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default]
>
> The gpio-led driver is being changed to avoid that problem, but it would also
> be good to make the board file use named initializers like every other one,
> so it won't happen again.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb•de>
FWIW,
Reviewed-by: Mika Westerberg <mika.westerberg@linux•intel.com>
prev parent reply other threads:[~2014-10-14 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <543b63d2.a479420a.486e.ffffb6e2@mx.google.com>
2014-10-13 8:46 ` next build: 304 warnings 0 failures (next/next-20141013) Russell King - ARM Linux
2014-10-13 9:12 ` Arnd Bergmann
2014-10-13 9:38 ` Marek Szyprowski
2014-10-14 8:54 ` Mika Westerberg
2014-10-14 9:17 ` Arnd Bergmann
2014-10-14 13:16 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014131643.GG2255@lahna.fi.intel.com \
--to=mika.westerberg@linux$(echo .)intel.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox