From: bjorn.andersson@sonymobile•com (Bjorn Andersson)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC 1/2] mfd: qcom-rpm: Expose sleep state resources to clients
Date: Tue, 11 Nov 2014 10:33:21 -0800 [thread overview]
Message-ID: <20141111183319.GD16980@sonymobile.com> (raw)
In-Reply-To: <20141111120457.GZ24004@x1>
On Tue 11 Nov 04:04 PST 2014, Lee Jones wrote:
> On Mon, 10 Nov 2014, Bjorn Andersson wrote:
>
> > Resources exposed from the RPM have an "active state" that is used during
> > normal operations and a "sleep state" that is used for HW assisted sleep
> > modes. Expose this in the api to let client drivers set the "sleep
> > state" as well.
>
> I assume you have users lined up which will request a sleeping state?
>
All users of this interface (regulators, clocks and bus scaling) will have to
be able to specify this.
[..]
> > @@ -359,8 +361,7 @@ int qcom_rpm_write(struct qcom_rpm *rpm, int resource, u32 *buf, size_t count)
> > RPM_CTRL_REG(rpm, RPM_REQ_SELECT + i));
> > }
> >
> > - writel_relaxed(RPM_ACTIVE_STATE,
> > - RPM_CTRL_REG(rpm, RPM_REQUEST_CONTEXT));
> > + writel_relaxed(BIT(state), RPM_CTRL_REG(rpm, RPM_REQUEST_CONTEXT));
>
> How are the state bits organised?
>
BIT(0) is active mode, BIT(1) is sleep mode, as specified below. I could add
some sanity checking here if you would like to.
[..]
> > diff --git a/include/linux/mfd/qcom_rpm.h b/include/linux/mfd/qcom_rpm.h
> > index a60798d..f0e70b2 100644
> > --- a/include/linux/mfd/qcom_rpm.h
> > +++ b/include/linux/mfd/qcom_rpm.h
> > +#define RPM_ACTIVE_STATE 0
> > +#define RPM_SLEEP_STATE 1
Regards,
Bjorn
next prev parent reply other threads:[~2014-11-11 18:33 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 22:52 [RFC 0/2] Qualcomm RPM sleep states Bjorn Andersson
2014-11-10 22:52 ` [RFC 1/2] mfd: qcom-rpm: Expose sleep state resources to clients Bjorn Andersson
2014-11-11 12:04 ` Lee Jones
2014-11-11 18:33 ` Bjorn Andersson [this message]
2014-11-12 9:52 ` Lee Jones
2014-11-12 14:45 ` Lina Iyer
2014-11-12 19:23 ` Bjorn Andersson
2014-11-19 18:06 ` Lina Iyer
2014-11-12 19:55 ` Bjorn Andersson
2014-11-10 22:52 ` [RFC 2/2] regulator: qcom-rpm: Implement RPM assisted disable Bjorn Andersson
2014-11-11 9:11 ` Andreas Färber
2014-11-11 18:34 ` Bjorn Andersson
2014-11-11 11:59 ` Lee Jones
2014-11-11 18:39 ` Bjorn Andersson
2014-11-11 14:21 ` Javier Martinez Canillas
2014-11-11 19:23 ` Bjorn Andersson
2014-11-21 23:10 ` [RFC 0/2] Qualcomm RPM sleep states Stephen Boyd
2014-11-21 23:27 ` Mark Brown
2014-11-21 23:43 ` Stephen Boyd
2014-11-21 23:54 ` Mark Brown
2014-11-22 0:03 ` Stephen Boyd
2014-11-22 0:16 ` Bjorn Andersson
2014-11-24 18:16 ` Mark Brown
2014-11-24 21:19 ` Stephen Boyd
2014-11-25 20:44 ` Mark Brown
2014-11-26 1:02 ` Stephen Boyd
2014-11-26 13:40 ` Mark Brown
2014-11-27 1:51 ` Stephen Boyd
2014-11-27 18:56 ` Mark Brown
2014-11-26 23:34 ` Bjorn Andersson
2014-11-27 19:02 ` Mark Brown
2014-11-27 19:42 ` Bjorn Andersson
2014-11-28 20:16 ` Mark Brown
2014-12-04 21:15 ` Stephen Boyd
2014-12-08 18:06 ` Bjorn Andersson
2014-12-08 19:39 ` Mark Brown
2014-12-08 20:55 ` Bjorn Andersson
2014-12-09 18:16 ` Mark Brown
2014-12-09 19:25 ` Bjorn Andersson
2014-12-09 20:28 ` Mark Brown
2014-12-11 22:36 ` Bjorn Andersson
2014-12-15 18:04 ` Mark Brown
2014-12-16 6:05 ` Bjorn Andersson
2014-12-26 17:09 ` Mark Brown
2014-12-29 21:54 ` Bjorn Andersson
2014-12-30 16:43 ` Mark Brown
2014-11-24 17:02 ` Bjorn Andersson
2014-11-24 21:19 ` Stephen Boyd
2014-11-24 21:59 ` Bjorn Andersson
2014-11-25 0:02 ` Stephen Boyd
2014-11-26 22:49 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111183319.GD16980@sonymobile.com \
--to=bjorn.andersson@sonymobile$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox