From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [GIT PULL] Third Round of Renesas ARM Based Soc Updates for v3.19
Date: Wed, 19 Nov 2014 22:16:27 +0100 [thread overview]
Message-ID: <201411192216.27740.arnd@arndb.de> (raw)
In-Reply-To: <cover.1415841454.git.horms+renesas@verge.net.au>
On Thursday 13 November 2014, Simon Horman wrote:
> ----------------------------------------------------------------
> Third Round of Renesas ARM Based Soc Updates for v3.19
>
> * Always build rcar setup for armv7
> - Fixes allmodconfig build fauilre caused by
> "ARM: shmobile: always build rcar setup for armv7"
> * Add restart callback to sh73a0
Pulled into next/soc, thanks!
> ----------------------------------------------------------------
> Arnd Bergmann (1):
> ARM: shmobile: always build rcar setup for armv7
>
> Geert Uytterhoeven (1):
> ARM: shmobile: sh73a0: Add restart callback
I'm not too happy about the restart handler here:
+#define RESCNT2 IOMEM(0xe6188020)
+static void sh73a0_restart(enum reboot_mode mode, const char *cmd)
+{
+ /* Do soft power on reset */
+ writel((1 << 31), RESCNT2);
+}
I see that you have the same thing in other SoCs, but I'd really want to
see this done properly at some point and likely won't take future patches
doing the same thing.
Please have a look@drivers/power/restart for how other platforms do
this. You probably need to add a device node for whatever IP block
holds the reset register and then have a driver. What exactly this
driver should look like depends of course on what other registers are
part of this block.
Arnd
next prev parent reply other threads:[~2014-11-19 21:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 1:20 [GIT PULL] Third Round of Renesas ARM Based Soc Updates for v3.19 Simon Horman
2014-11-13 1:20 ` [PATCH 1/2] ARM: shmobile: sh73a0: Add restart callback Simon Horman
2014-11-13 1:20 ` [PATCH 2/2] ARM: shmobile: always build rcar setup for armv7 Simon Horman
2014-11-13 18:50 ` [GIT PULL] Third Round of Renesas ARM Based Soc Updates for v3.19 Sergei Shtylyov
2014-11-14 0:32 ` Simon Horman
2014-11-19 21:16 ` Arnd Bergmann [this message]
2014-11-20 0:42 ` Simon Horman
2014-11-20 7:56 ` Geert Uytterhoeven
2014-11-20 9:04 ` Arnd Bergmann
2014-11-20 9:19 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411192216.27740.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox