From: horms@verge•net.au (Simon Horman)
To: linux-arm-kernel@lists•infradead.org
Subject: [GIT PULL] Third Round of Renesas ARM Based Soc Updates for v3.19
Date: Thu, 20 Nov 2014 09:42:36 +0900 [thread overview]
Message-ID: <20141120004236.GC5065@verge.net.au> (raw)
In-Reply-To: <201411192216.27740.arnd@arndb.de>
[ CC Geert ]
On Wed, Nov 19, 2014 at 10:16:27PM +0100, Arnd Bergmann wrote:
> On Thursday 13 November 2014, Simon Horman wrote:
> > ----------------------------------------------------------------
> > Third Round of Renesas ARM Based Soc Updates for v3.19
> >
> > * Always build rcar setup for armv7
> > - Fixes allmodconfig build fauilre caused by
> > "ARM: shmobile: always build rcar setup for armv7"
> > * Add restart callback to sh73a0
>
> Pulled into next/soc, thanks!
>
> > ----------------------------------------------------------------
> > Arnd Bergmann (1):
> > ARM: shmobile: always build rcar setup for armv7
> >
> > Geert Uytterhoeven (1):
> > ARM: shmobile: sh73a0: Add restart callback
>
> I'm not too happy about the restart handler here:
>
> +#define RESCNT2 IOMEM(0xe6188020)
> +static void sh73a0_restart(enum reboot_mode mode, const char *cmd)
> +{
> + /* Do soft power on reset */
> + writel((1 << 31), RESCNT2);
> +}
>
> I see that you have the same thing in other SoCs, but I'd really want to
> see this done properly at some point and likely won't take future patches
> doing the same thing.
>
> Please have a look at drivers/power/restart for how other platforms do
> this. You probably need to add a device node for whatever IP block
> holds the reset register and then have a driver. What exactly this
> driver should look like depends of course on what other registers are
> part of this block.
Hi Arnd,
thanks for your feedback and likewise for the kzm9g.
I will follow this up.
next prev parent reply other threads:[~2014-11-20 0:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 1:20 [GIT PULL] Third Round of Renesas ARM Based Soc Updates for v3.19 Simon Horman
2014-11-13 1:20 ` [PATCH 1/2] ARM: shmobile: sh73a0: Add restart callback Simon Horman
2014-11-13 1:20 ` [PATCH 2/2] ARM: shmobile: always build rcar setup for armv7 Simon Horman
2014-11-13 18:50 ` [GIT PULL] Third Round of Renesas ARM Based Soc Updates for v3.19 Sergei Shtylyov
2014-11-14 0:32 ` Simon Horman
2014-11-19 21:16 ` Arnd Bergmann
2014-11-20 0:42 ` Simon Horman [this message]
2014-11-20 7:56 ` Geert Uytterhoeven
2014-11-20 9:04 ` Arnd Bergmann
2014-11-20 9:19 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120004236.GC5065@verge.net.au \
--to=horms@verge$(echo .)net.au \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox