From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 7/7] ARM: mvebu: Add Armada 385 Access Point Development Board support
Date: Tue, 6 Jan 2015 19:07:57 +0100 [thread overview]
Message-ID: <20150106180757.GC25030@lunn.ch> (raw)
In-Reply-To: <20150106173101.GB7853@lukather>
Hi Maxime
> > Maybe add
> >
> > stdout-path = &uart1;
>
> Does that even work with the 8250? Last time I tried with a 3.18, it
> didn't, and you still needed the console= bootargs.
It is for the bootloader, not Linux. barebox will use this, etc. I
think there are also plans for linux to use this. Not sure how far it
has got.
> > > + i2c0: i2c at 11000 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&i2c0_pins>;
> > > + status = "okay";
> > > + clock-frequency = <100000>;
> > > + };
> > > +
> > > + i2c1: i2c at 11100 {
> > > + status = "okay";
> > > + clock-frequency = <100000>;
> > > + };
> >
> > Is there anything on these two i2c busses?
>
> One goes to some pin of the mPCIe slot, the other is connected to the
> EEPROM.
So could you add the EEPROM, and a comment about the mPCIe slot?
> > If not, why enable them and increase the clock speed?
>
> The clock speed is not increased, it's actually the driver's default.
Dio you need this then? Is it in the dtsi file?
> > > + uart0: serial at 12000 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart0_pins>;
> > > + status = "okay";
> > > + };
> > > +
> > > + uart1: serial at 12100 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart1_pins>;
> > > + status = "okay";
> > > + };
> >
> > If it is not obvious from the silk screen, could you describe which
> > connector this uart is on, what pins are what?
>
> There's two UART connectors documented in the user guide (JP8 and
> JP9). UART1 is also connected to a FTDI chip, that is exposed through
> a mini-USB connector.
I'm guessing the user guide is only available under NDA? Where as you
can get the hardware without an NDA. At least i have a 370-rd, but no
NDA. So some minimal documentation would be nice. Especially since it
is backwards around to what most people would expect.
> > > +
> > > + ethernet at 30000 {
> > > + status = "okay";
> > > + phy = <&phy1>;
> > > + phy-mode = "sgmii";
> > > + };
> > > +
> > > + ethernet at 34000 {
> > > + status = "okay";
> > > + phy = <&phy2>;
> > > + phy-mode = "sgmii";
> > > + };
> > > +
> > > + ethernet at 70000 {
> > > + pinctrl-names = "default";
> > > +
> > > + /*
> > > + * The Reference Clock 0 is used to
> > > + * provide a clock to the PHY
> > > + */
> >
> > Does this clock need enabling? Should it be listed in the clocks
> > property?
>
> From what I understood, this clock is always running, it's just
> exposed to some external pin, and hence needs some muxing.
O.K, thanks for the explanation.
Andrew
next prev parent reply other threads:[~2015-01-06 18:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 15:28 [PATCH v2 0/7] ARM: mvebu: Add Armada 385 AP support Maxime Ripard
2015-01-06 15:28 ` [PATCH v2 1/7] ARM: mvebu: Rename DEBUG_LL to indicate UART index Maxime Ripard
2015-01-06 21:07 ` Gregory CLEMENT
2015-01-06 15:28 ` [PATCH v2 2/7] ARM: mvebu: Add UART1 as DEBUG_LL possible target Maxime Ripard
2015-01-06 21:08 ` Gregory CLEMENT
2015-01-06 15:28 ` [PATCH v2 3/7] ARM: mvebu: a38x: Fix node names Maxime Ripard
2015-01-06 21:10 ` Gregory CLEMENT
2015-01-06 15:28 ` [PATCH v2 4/7] pinctrl: mvebu: a38x: Add UART1 muxing options Maxime Ripard
2015-01-06 15:28 ` [PATCH v2 5/7] ARM: mvebu: A38x: Remove redundant pinctrl informations Maxime Ripard
2015-01-06 21:11 ` Gregory CLEMENT
2015-01-06 15:28 ` [PATCH v2 6/7] ARM: mvebu: Add a number of pinctrl functions Maxime Ripard
2015-01-06 21:25 ` Gregory CLEMENT
2015-01-06 15:28 ` [PATCH v2 7/7] ARM: mvebu: Add Armada 385 Access Point Development Board support Maxime Ripard
2015-01-06 15:57 ` Andrew Lunn
2015-01-06 17:31 ` Maxime Ripard
2015-01-06 18:07 ` Andrew Lunn [this message]
2015-01-07 9:59 ` Maxime Ripard
2015-01-07 14:34 ` Andrew Lunn
2015-01-07 16:26 ` Gregory CLEMENT
2015-01-08 15:21 ` Nadav Haklai
2015-01-06 21:47 ` Gregory CLEMENT
2015-01-07 9:27 ` Maxime Ripard
2015-01-07 15:25 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106180757.GC25030@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox