From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 7/7] ARM: mvebu: Add Armada 385 Access Point Development Board support
Date: Tue, 06 Jan 2015 22:47:39 +0100 [thread overview]
Message-ID: <54AC57FB.8000003@free-electrons.com> (raw)
In-Reply-To: <1420558100-4700-8-git-send-email-maxime.ripard@free-electrons.com>
Hi Maxime,
[...]
> + spi-flash at 0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "st,m25p128";
> + reg = <0>; /* Chip select 0 */
> + spi-max-frequency = <108000000>;
The SPI flahs used on the AP board is the same that the one used on the GP board:
M25P128-VMF6P and the maximum frequency it can handle is 50MHz.
[...]
> +
> + mdio at 72004 {
> + pinctrl-names = <&mdio_pins>;
> +
> + phy0: ethernet-phy at 0 {
Why don't you use the PHY address after the '@' ?
Here I expected something like
phy0: ethernet-phy at 1 {
> + reg = <1>;
> + };
> +
> + phy1: ethernet-phy at 1 {
and here:
phy0: ethernet-phy at 6 {
> + reg = <6>;
> + };
> +
> + phy2: ethernet-phy at 2 {
and here:
phy0: ethernet-phy at 4 {
> + reg = <4>;
> + };
> + };
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-01-06 21:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 15:28 [PATCH v2 0/7] ARM: mvebu: Add Armada 385 AP support Maxime Ripard
2015-01-06 15:28 ` [PATCH v2 1/7] ARM: mvebu: Rename DEBUG_LL to indicate UART index Maxime Ripard
2015-01-06 21:07 ` Gregory CLEMENT
2015-01-06 15:28 ` [PATCH v2 2/7] ARM: mvebu: Add UART1 as DEBUG_LL possible target Maxime Ripard
2015-01-06 21:08 ` Gregory CLEMENT
2015-01-06 15:28 ` [PATCH v2 3/7] ARM: mvebu: a38x: Fix node names Maxime Ripard
2015-01-06 21:10 ` Gregory CLEMENT
2015-01-06 15:28 ` [PATCH v2 4/7] pinctrl: mvebu: a38x: Add UART1 muxing options Maxime Ripard
2015-01-06 15:28 ` [PATCH v2 5/7] ARM: mvebu: A38x: Remove redundant pinctrl informations Maxime Ripard
2015-01-06 21:11 ` Gregory CLEMENT
2015-01-06 15:28 ` [PATCH v2 6/7] ARM: mvebu: Add a number of pinctrl functions Maxime Ripard
2015-01-06 21:25 ` Gregory CLEMENT
2015-01-06 15:28 ` [PATCH v2 7/7] ARM: mvebu: Add Armada 385 Access Point Development Board support Maxime Ripard
2015-01-06 15:57 ` Andrew Lunn
2015-01-06 17:31 ` Maxime Ripard
2015-01-06 18:07 ` Andrew Lunn
2015-01-07 9:59 ` Maxime Ripard
2015-01-07 14:34 ` Andrew Lunn
2015-01-07 16:26 ` Gregory CLEMENT
2015-01-08 15:21 ` Nadav Haklai
2015-01-06 21:47 ` Gregory CLEMENT [this message]
2015-01-07 9:27 ` Maxime Ripard
2015-01-07 15:25 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AC57FB.8000003@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox