public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: olof@lixom•net (Olof Johansson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2] ARM: dts: Only build dtb if associated Arch and/or SoC is enabled
Date: Mon, 12 Jan 2015 14:42:03 -0800	[thread overview]
Message-ID: <20150112224203.GL22090@quad.lixom.net> (raw)
In-Reply-To: <1419920427-29121-1-git-send-email-pbrobinson@gmail.com>

On Tue, Dec 30, 2014 at 06:20:27AM +0000, Peter Robinson wrote:
> A number of arches (EXYNOS/IMX/TEGRA) are separated out into finer grained
> definitions whether it be sub ARCH or SOC definitions. The device tree blobs
> should only be built if the specific option is enabled that supports that
> device or it might be that there's an expectation that the device is supported
> when in actual fact it's not. This ensures only the relevant bits are built.
> 
> Also standardised the line break between the arch/soc definitions and the
> dtbs to be on separate lines for better consistency as per feedback.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail•com>
> Reviewed-by: Lucas Stach <l.stach@pengutronix•de>
> Acked-by: Thierry Reding <treding@nvidia•com>
> Acked-by: Stephen Warren <swarren@nvidia•com>
> Acked-by: Shawn Guo <shawn.guo@freescale•com>
> ---
>  arch/arm/boot/dts/Makefile | 213 ++++++++++++++++++++++++++++++---------------
>  1 file changed, 141 insertions(+), 72 deletions(-)

(adding Nicolas on cc)

Nice cleanup, but I really wish we had split up into subdirectories on ARM
much earlier. Doing that now is too much churn.

AT91 now sticks out a bit with its special case in formatting. Could be
worth changing at some point.

I've applied this on next/dt now, hopefully it won't become too much of
a headache of conflicts during this release cycle. At least doing it on that
branch should keep us from exposing it up outside our tree.



-Olof

  reply	other threads:[~2015-01-12 22:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-30  6:20 [PATCH V2] ARM: dts: Only build dtb if associated Arch and/or SoC is enabled Peter Robinson
2015-01-12 22:42 ` Olof Johansson [this message]
2015-01-13 12:23   ` Arnd Bergmann
2015-01-13 18:07     ` Olof Johansson
2015-01-13 14:43   ` [PATCH] ARM: dts: re-fromat AT91 part to match other entries Nicolas Ferre
2015-01-13 23:09     ` Olof Johansson
2015-01-13 23:47       ` Alexandre Belloni
2015-01-14  9:05         ` Arnd Bergmann
2015-01-26 15:45           ` Nicolas Ferre
2015-01-27  2:13             ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150112224203.GL22090@quad.lixom.net \
    --to=olof@lixom$(echo .)net \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox