From: sylvain.rochet@finsecur•com (Sylvain Rochet)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv4 3/6] USB: host: ohci-at91: Stop/start USB PLL for all sleep modes
Date: Sun, 18 Jan 2015 22:17:28 +0100 [thread overview]
Message-ID: <20150118211728.GA21128@gradator.net> (raw)
In-Reply-To: <1421609766-11204-4-git-send-email-sylvain.rochet@finsecur.com>
Hello,
On Sun, Jan 18, 2015 at 08:36:03PM +0100, Sylvain Rochet wrote:
> Disable/unprepare clocks without testing the sleep target_state, removed
> the at91_suspend_entering_slow_clock() call (which is only a
> target_state == PM_SUSPEND_MEM).
>
> Other kind of suspend now benefit from the power save induced by this
> PLL deactivation. The resume penalty is about 500 us, which is not
> negligible but acceptable considering the amount of power we are saving.
Well, this patch actually lights up a previous issue on wake up support.
This device needs to be continuously clocked to provide wake up support,
previously, if STANDBY target were chosen the device were
enable_irq_wake-prepared and clock still active and if MEM target were
chosen the device were also enable_irq_wake-prepared but not clocked
anymore, which is wrong, but not so wrong.
This patch actually breaks wake up support for STANDBY sleep target. I
am going to propose a v5 which reinitiate at91_suspend_entering_slow_clock()
and fix wake up support on this driver.
Sylvain
next prev parent reply other threads:[~2015-01-18 21:17 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 19:41 [PATCH] USB: host: ehci_atmel: Add suspend/resume support Sylvain Rochet
2015-01-17 1:34 ` Alexandre Belloni
2015-01-17 9:36 ` Boris Brezillon
2015-01-17 10:43 ` Sylvain Rochet
2015-01-17 12:58 ` Boris Brezillon
2015-01-17 15:36 ` [PATCHv2 1/2] " Sylvain Rochet
2015-01-17 15:36 ` [PATCHv2 2/2] USB: host: ohci_at91: Stop/start USB PLL for all sleep modes Sylvain Rochet
2015-01-17 17:05 ` Boris Brezillon
2015-01-19 0:18 ` Alexandre Belloni
2015-01-17 16:55 ` [PATCHv2 1/2] USB: host: ehci_atmel: Add suspend/resume support Boris Brezillon
2015-01-17 16:03 ` [PATCH] " Sylvain Rochet
2015-01-17 18:23 ` [PATCH 1/3] USB: host: ehci_atmel: Move global variables to private struct Sylvain Rochet
2015-01-17 18:23 ` [PATCH 2/3] USB: host: ohci_at91: " Sylvain Rochet
2015-01-17 18:23 ` [PATCH 3/3] USB: host: ohci_at91: usb_hcd_at91_probe(), remove useless stack initialisation Sylvain Rochet
2015-01-17 19:18 ` [PATCH 1/3] USB: host: ehci_atmel: Move global variables to private struct Boris Brezillon
2015-01-17 20:30 ` Alan Stern
2015-01-17 21:25 ` [PATCHv3 0/5] USB: host: Atmel OHCI and EHCI drivers improvements Sylvain Rochet
2015-01-17 21:25 ` [PATCHv3 1/5] USB: host: ehci_atmel: Add suspend/resume support Sylvain Rochet
2015-01-17 22:22 ` Sergei Shtylyov
2015-01-17 22:49 ` Sylvain Rochet
2015-01-18 8:14 ` Boris Brezillon
2015-01-18 19:55 ` Sergei Shtylyov
2015-01-17 21:25 ` [PATCHv3 2/5] USB: host: ohci_at91: Stop/start USB PLL for all sleep modes Sylvain Rochet
2015-01-17 21:25 ` [PATCHv3 3/5] USB: host: ehci_atmel: Move global variables to private struct Sylvain Rochet
2015-01-17 21:25 ` [PATCHv3 4/5] USB: host: ohci_at91: " Sylvain Rochet
2015-01-17 21:25 ` [PATCHv3 5/5] USB: host: ohci_at91: usb_hcd_at91_probe(), remove useless stack initialisation Sylvain Rochet
2015-01-18 17:20 ` [PATCHv3 0/5] USB: host: Atmel OHCI and EHCI drivers improvements Alan Stern
2015-01-18 19:36 ` [PATCHv4 0/6] " Sylvain Rochet
2015-01-18 19:36 ` [PATCHv4 1/6] USB: host: ehci-atmel: Add suspend/resume support Sylvain Rochet
2015-01-18 19:36 ` [PATCHv4 2/6] USB: host: ohci-at91: Use struct dev_pm_ops instead of struct platform_driver Sylvain Rochet
2015-01-18 19:36 ` [PATCHv4 3/6] USB: host: ohci-at91: Stop/start USB PLL for all sleep modes Sylvain Rochet
2015-01-18 21:17 ` Sylvain Rochet [this message]
2015-01-18 22:25 ` [PATCHv5 0/6] USB: host: Atmel OHCI and EHCI drivers improvements Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 1/6] USB: host: ehci-atmel: Add suspend/resume support Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 2/6] USB: host: ohci-at91: Use struct dev_pm_ops instead of struct platform_driver Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 3/6] USB: host: ehci-atmel: Move global variables to private struct Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 4/6] USB: host: ohci-at91: Fix wake-up support Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 5/6] USB: host: ohci-at91: Move global variables to private struct Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 6/6] USB: host: ohci-at91: usb_hcd_at91_probe(), remove useless stack initialisation Sylvain Rochet
2015-01-19 13:34 ` [PATCHv5 0/6] USB: host: Atmel OHCI and EHCI drivers improvements Nicolas Ferre
2015-01-19 13:43 ` Sylvain Rochet
2015-01-19 15:48 ` Alan Stern
2015-01-18 19:36 ` [PATCHv4 4/6] USB: host: ehci-atmel: Move global variables to private struct Sylvain Rochet
2015-01-18 19:36 ` [PATCHv4 5/6] USB: host: ohci-at91: " Sylvain Rochet
2015-01-18 19:36 ` [PATCHv4 6/6] USB: host: ohci-at91: usb_hcd_at91_probe(), remove useless stack initialisation Sylvain Rochet
2015-01-18 19:42 ` [PATCHv3 0/5] USB: host: Atmel OHCI and EHCI drivers improvements Sylvain Rochet
2015-01-17 21:27 ` [PATCH 1/3] USB: host: ehci_atmel: Move global variables to private struct Sylvain Rochet
2015-01-19 0:17 ` [PATCH] USB: host: ehci_atmel: Add suspend/resume support Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150118211728.GA21128@gradator.net \
--to=sylvain.rochet@finsecur$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox