From: sergei.shtylyov@cogentembedded•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv3 1/5] USB: host: ehci_atmel: Add suspend/resume support
Date: Sun, 18 Jan 2015 22:55:00 +0300 [thread overview]
Message-ID: <54BC0F94.6030402@cogentembedded.com> (raw)
In-Reply-To: <20150117224900.GA22439@gradator.net>
Hello.
On 01/18/2015 01:49 AM, Sylvain Rochet wrote:
>> There's little inconsistency in your patch subjects: you're using
>> '_' but the files you're modifying are named using '-'...
> Indeed.
>>> @@ -187,6 +217,8 @@ static struct platform_driver ehci_atmel_driver = {
>>> .probe = ehci_atmel_drv_probe,
>>> .remove = ehci_atmel_drv_remove,
>>> .shutdown = usb_hcd_platform_shutdown,
>>> + .suspend = ehci_atmel_drv_suspend,
>>> + .resume = ehci_atmel_drv_resume,
>>
>> I think you should use 'struct dev_pm_ops' now.
I'm not sure but perhaps scripts/checkpatch.pl would complain about the
old-style PM methods... should check.
> This way ?
> static int ehci_atmel_drv_suspend(struct device *dev)
> {
> struct usb_hcd *hcd = dev_get_drvdata(dev);
> (...)
>
>
> static SIMPLE_DEV_PM_OPS(ehci_atmel_pm_ops, ehci_atmel_drv_suspend, ehci_atmel_drv_resume);
>
> (...)
> .driver = {
> .pm = &ehci_atmel_pm_ops,
> }
> (...)
Yes, probably.
> Should I send a v4 or can I send this change separately on top of the
> previous change ?
v4 please.
> Sylvain
WBR, Sergei
next prev parent reply other threads:[~2015-01-18 19:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 19:41 [PATCH] USB: host: ehci_atmel: Add suspend/resume support Sylvain Rochet
2015-01-17 1:34 ` Alexandre Belloni
2015-01-17 9:36 ` Boris Brezillon
2015-01-17 10:43 ` Sylvain Rochet
2015-01-17 12:58 ` Boris Brezillon
2015-01-17 15:36 ` [PATCHv2 1/2] " Sylvain Rochet
2015-01-17 15:36 ` [PATCHv2 2/2] USB: host: ohci_at91: Stop/start USB PLL for all sleep modes Sylvain Rochet
2015-01-17 17:05 ` Boris Brezillon
2015-01-19 0:18 ` Alexandre Belloni
2015-01-17 16:55 ` [PATCHv2 1/2] USB: host: ehci_atmel: Add suspend/resume support Boris Brezillon
2015-01-17 16:03 ` [PATCH] " Sylvain Rochet
2015-01-17 18:23 ` [PATCH 1/3] USB: host: ehci_atmel: Move global variables to private struct Sylvain Rochet
2015-01-17 18:23 ` [PATCH 2/3] USB: host: ohci_at91: " Sylvain Rochet
2015-01-17 18:23 ` [PATCH 3/3] USB: host: ohci_at91: usb_hcd_at91_probe(), remove useless stack initialisation Sylvain Rochet
2015-01-17 19:18 ` [PATCH 1/3] USB: host: ehci_atmel: Move global variables to private struct Boris Brezillon
2015-01-17 20:30 ` Alan Stern
2015-01-17 21:25 ` [PATCHv3 0/5] USB: host: Atmel OHCI and EHCI drivers improvements Sylvain Rochet
2015-01-17 21:25 ` [PATCHv3 1/5] USB: host: ehci_atmel: Add suspend/resume support Sylvain Rochet
2015-01-17 22:22 ` Sergei Shtylyov
2015-01-17 22:49 ` Sylvain Rochet
2015-01-18 8:14 ` Boris Brezillon
2015-01-18 19:55 ` Sergei Shtylyov [this message]
2015-01-17 21:25 ` [PATCHv3 2/5] USB: host: ohci_at91: Stop/start USB PLL for all sleep modes Sylvain Rochet
2015-01-17 21:25 ` [PATCHv3 3/5] USB: host: ehci_atmel: Move global variables to private struct Sylvain Rochet
2015-01-17 21:25 ` [PATCHv3 4/5] USB: host: ohci_at91: " Sylvain Rochet
2015-01-17 21:25 ` [PATCHv3 5/5] USB: host: ohci_at91: usb_hcd_at91_probe(), remove useless stack initialisation Sylvain Rochet
2015-01-18 17:20 ` [PATCHv3 0/5] USB: host: Atmel OHCI and EHCI drivers improvements Alan Stern
2015-01-18 19:36 ` [PATCHv4 0/6] " Sylvain Rochet
2015-01-18 19:36 ` [PATCHv4 1/6] USB: host: ehci-atmel: Add suspend/resume support Sylvain Rochet
2015-01-18 19:36 ` [PATCHv4 2/6] USB: host: ohci-at91: Use struct dev_pm_ops instead of struct platform_driver Sylvain Rochet
2015-01-18 19:36 ` [PATCHv4 3/6] USB: host: ohci-at91: Stop/start USB PLL for all sleep modes Sylvain Rochet
2015-01-18 21:17 ` Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 0/6] USB: host: Atmel OHCI and EHCI drivers improvements Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 1/6] USB: host: ehci-atmel: Add suspend/resume support Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 2/6] USB: host: ohci-at91: Use struct dev_pm_ops instead of struct platform_driver Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 3/6] USB: host: ehci-atmel: Move global variables to private struct Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 4/6] USB: host: ohci-at91: Fix wake-up support Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 5/6] USB: host: ohci-at91: Move global variables to private struct Sylvain Rochet
2015-01-18 22:25 ` [PATCHv5 6/6] USB: host: ohci-at91: usb_hcd_at91_probe(), remove useless stack initialisation Sylvain Rochet
2015-01-19 13:34 ` [PATCHv5 0/6] USB: host: Atmel OHCI and EHCI drivers improvements Nicolas Ferre
2015-01-19 13:43 ` Sylvain Rochet
2015-01-19 15:48 ` Alan Stern
2015-01-18 19:36 ` [PATCHv4 4/6] USB: host: ehci-atmel: Move global variables to private struct Sylvain Rochet
2015-01-18 19:36 ` [PATCHv4 5/6] USB: host: ohci-at91: " Sylvain Rochet
2015-01-18 19:36 ` [PATCHv4 6/6] USB: host: ohci-at91: usb_hcd_at91_probe(), remove useless stack initialisation Sylvain Rochet
2015-01-18 19:42 ` [PATCHv3 0/5] USB: host: Atmel OHCI and EHCI drivers improvements Sylvain Rochet
2015-01-17 21:27 ` [PATCH 1/3] USB: host: ehci_atmel: Move global variables to private struct Sylvain Rochet
2015-01-19 0:17 ` [PATCH] USB: host: ehci_atmel: Add suspend/resume support Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BC0F94.6030402@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox